Bug 1676565 - openshift_node/defaults/main.yml using a wrong journald value
Summary: openshift_node/defaults/main.yml using a wrong journald value
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.11.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 3.11.z
Assignee: Russell Teague
QA Contact: Johnny Liu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-12 15:06 UTC by Javier Ramirez
Modified: 2020-05-14 18:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Default journald configuration had SystemKeepFree parameter set to percentages Consequence: journald doesn't accept percentage values in SystemKeepFree, so this setting had no effect and could cause disk to be filled up Fix: This parameter was removed from default settings Result: Users have to update journald_vars_to_replace with absolute value in SystemKeepFree to avoid disk filling in
Clone Of:
Environment:
Last Closed: 2020-05-14 18:47:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift openshift-ansible pull 11187 0 None closed Removing SystemKeepFree to use default value 2020-05-14 18:47:04 UTC
Red Hat Product Errata RHBA-2019:0407 0 None None None 2019-03-14 02:18:01 UTC

Description Javier Ramirez 2019-02-12 15:06:33 UTC
Description of problem:
In /roles/openshift_node/defaults/main.yml there is a setting - { var: SystemKeepFree, val: 20% } that is incorrect, journald doesnt accept percentages as input for config files as specified in https://bugzilla.redhat.com/show_bug.cgi?id=874631 '

This cause log disk filling up because of wrong default configuration settings in openshift-ansible.

How reproducible:
Always

Actual results:
Log disk filling up because of wrong default configuration settings in openshift-ansible.

Expected results:
Good journald settings to be used


Additional info:
While We wait until https://bugzilla.redhat.com/show_bug.cgi?id=874631 is resolved and therefore the percentage value would be correct, we should ammend the main.yml file with a fixed value like:
- { var: SystemKeepFree, val: 1G }

Comment 1 Scott Dodson 2019-02-12 19:58:30 UTC
Reading through the referenced bug it seems like the default if not specified is 15% but when specifying a value it must be in absolute units. So I think we should just drop this value as it's not possible to specify a percentage via configuration and it's not possible to come up with a reasonable absolute value otherwise.

Comment 2 Javier Ramirez 2019-02-13 11:24:36 UTC
Created upstream Pull Request:
https://github.com/openshift/openshift-ansible/pull/11187

Comment 3 Scott Dodson 2019-02-13 15:01:58 UTC
Thanks Javier!

Comment 4 Vadim Rutkovsky 2019-02-20 09:47:18 UTC
Fix is available in openshift-ansible-3.11.84-1

Comment 5 Gaoyun Pei 2019-02-21 02:56:12 UTC
Verify this bug with openshift-ansible-3.11.87-1.git.0.a7b07ff.el7.noarch.rpm

SystemKeepFree was removed from roles/openshift_node/defaults/main.yml

After a fresh installation, no such setting in journald.conf

[root@qe-gpei-2master-registry-router-etcd-1 ~]# grep SystemKeepFree /etc/systemd/journald.conf
[root@qe-gpei-2master-registry-router-etcd-1 ~]#


Note You need to log in before you can comment on or make changes to this bug.