Bug 1676910 - Approver user cannot deny the request
Summary: Approver user cannot deny the request
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.10.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: GA
: 5.11.0
Assignee: Hilda Stastna
QA Contact: Jaroslav Henner
Red Hat CloudForms Documentation
URL:
Whiteboard:
: 1685073 (view as bug list)
Depends On:
Blocks: 1686090
TreeView+ depends on / blocked
 
Reported: 2019-02-13 15:06 UTC by Jaroslav Henner
Modified: 2019-12-17 12:35 UTC (History)
11 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1686090 (view as bug list)
Environment:
Last Closed: 2019-12-13 14:54:50 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
approver.png (72.55 KB, image/png)
2019-02-13 15:06 UTC, Jaroslav Henner
no flags Details

Description Jaroslav Henner 2019-02-13 15:06:14 UTC
Created attachment 1534432 [details]
approver.png

Description of problem:
The user with in the approvers group cannot deny a approve request. Only Approve button is shown.

Version-Release number of selected component (if applicable):
5.10.0.33.20190129203322_85a1e4e

How reproducible:
2/2

Steps to Reproduce:
1. Create user, add him to the approvers user group
2. Create a VM creation request (set vm count to >1 to make the request approval pending)
3. Observe the request with the created approver user

Actual results:
Only approve button shown

Expected results:
Approve and deny buttons shown.

Additional info:

Comment 5 Hilda Stastna 2019-02-20 10:40:23 UTC
fixing https://github.com/ManageIQ/manageiq-ui-classic/pull/5255

Comment 6 Harpreet Kataria 2019-03-04 14:12:36 UTC
*** Bug 1685073 has been marked as a duplicate of this bug. ***

Comment 7 CFME Bot 2019-03-04 14:31:52 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/3822b487e707bd92d89939d0df1dc4ef041a92ab
commit 3822b487e707bd92d89939d0df1dc4ef041a92ab
Author:     Hilda Stastna <hstastna>
AuthorDate: Wed Feb 20 05:11:46 2019 -0500
Commit:     Hilda Stastna <hstastna>
CommitDate: Wed Feb 20 05:11:46 2019 -0500

    Allow Approver user to deny the request

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1676910

 app/helpers/application_helper/button/miq_request.rb | 2 +-
 app/helpers/application_helper/toolbar/miq_request_center.rb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comment 9 Jaroslav Henner 2019-07-02 09:55:54 UTC
I could find the required buttons and the request denial as well as approval did work


Note You need to log in before you can comment on or make changes to this bug.