Bug 1677166 - [FFU] Package openstack-tripleo-validations requirement to perform FFU
Summary: [FFU] Package openstack-tripleo-validations requirement to perform FFU
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-tripleoclient
Version: 13.0 (Queens)
Hardware: All
OS: Linux
high
high
Target Milestone: z5
: 13.0 (Queens)
Assignee: Alex Schultz
QA Contact: Sasha Smolyak
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-14 08:00 UTC by Gyanendra Kumar
Modified: 2019-03-14 13:55 UTC (History)
14 users (show)

Fixed In Version: python-tripleoclient-9.2.6-8.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-14 13:55:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1816447 0 None None None 2019-02-18 15:06:05 UTC
RDO 18894 0 None None None 2019-02-18 15:10:25 UTC
Red Hat Product Errata RHBA-2019:0448 0 None None None 2019-03-14 13:55:29 UTC

Description Gyanendra Kumar 2019-02-14 08:00:50 UTC
Description of problem: Requirement of package openstack-tripleo-validations to perform FFU


Version-Release number of selected component (if applicable):

OSP10

How reproducible:


Steps to Reproduce:
1.If we install OSP10 undercloud with below config:

~~~
$ egrep -v '^$|^#' undercloud.conf 
[DEFAULT]
local_ip = 192.168.24.1/24
network_gateway = 192.168.24.1
undercloud_public_vip = 192.168.24.2
undercloud_admin_vip = 192.168.24.3
local_interface = eno3
network_cidr = 192.168.24.0/24
dhcp_start = 192.168.24.5
dhcp_end = 192.168.24.25
inspection_iprange = 192.168.24.100,192.168.24.120
enable_tempest = false
enable_telemetry = false
enable_ui = false
enable_validations = false
[auth]
~~~

This will not install package openstack-tripleo-validations.

2. Install OSP10(My environemt was SRIOV but i think this bug applies to all)
3. Verify Overcloud OSP10 and it is working fine
4. Perform upgrade of undercloud from OSP10 - OSp11 - OSP12- OSP13
5.  performe ffwd-upgrade prepare , it is also successful
~~~
openstack overcloud ffwd-upgrade prepare  \
--timeout 120 \
--templates /usr/share/openstack-tripleo-heat-templates \
--stack overcloud \
-r /home/stack/templates/roles_data.yaml \
-e /home/stack/templates/overcloud_images.yaml \
-e /home/stack/templates/environments/network-isolation.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/neutron-sriov.yaml \
-e /home/stack/templates/environments/network-environment.yaml \
-e /home/stack/templates/environments/cloudname.yaml \
-e /home/stack/templates/node-info.yaml \
-e /home/stack/templates/repo_script.yaml
~~~
6. Run "openstack overcloud ffwd-upgrade run" and it will fail immediately.

7. When run command with --debug we see the it is trying to generate an ansible invertoty and binary is missing. Binary is coming from  package openstack-tripleo-validations. 


Actual results:

"openstack overcloud ffwd-upgrade run " failed


Expected results:
openstack overcloud ffwd-upgrade run  should be successful.

Additional info:

Config and package difference


From Not working:

$ sudo rpm -qa|grep -i triple
puppet-tripleo-5.6.8-20.el7ost.noarch
python-tripleoclient-5.4.6-1.el7ost.noarch
openstack-tripleo-puppet-elements-5.3.3-4.el7ost.noarch
openstack-tripleo-0.0.8-0.3.4de13b3git.el7ost.noarch
openstack-tripleo-heat-templates-5.3.10-23.el7ost.noarch
openstack-tripleo-image-elements-5.3.3-1.el7ost.noarch
openstack-tripleo-common-5.4.7-6.el7ost.noarch

$ egrep -v '^$|^#' undercloud.conf 
[DEFAULT]
local_ip = 192.168.24.1/24
network_gateway = 192.168.24.1
undercloud_public_vip = 192.168.24.2
undercloud_admin_vip = 192.168.24.3
local_interface = eno3
network_cidr = 192.168.24.0/24
dhcp_start = 192.168.24.5
dhcp_end = 192.168.24.25
inspection_iprange = 192.168.24.100,192.168.24.120
enable_tempest = false
enable_telemetry = false
enable_ui = false
enable_validations = false
[auth]
$


From working environment

sudo rpm -qa|grep -i triple
puppet-tripleo-5.6.8-20.el7ost.noarch
python-tripleoclient-5.4.6-1.el7ost.noarch
openstack-tripleo-image-elements-5.3.3-1.el7ost.noarch
openstack-tripleo-common-5.4.7-6.el7ost.noarch
openstack-tripleo-0.0.8-0.3.4de13b3git.el7ost.noarch
openstack-tripleo-validations-5.1.4-3.el7ost.noarch
openstack-tripleo-puppet-elements-5.3.3-4.el7ost.noarch
openstack-tripleo-heat-templates-5.3.10-23.el7ost.noarch
openstack-tripleo-ui-1.2.1-1.el7ost.noarch
[stack@director10 ~]$ 
[stack@director10 ~]$ 
[stack@director10 ~]$ 
[stack@director10 ~]$ egrep -v '^$|^#' undercloud.conf
[DEFAULT]
local_ip = 192.168.60.1/24
network_gateway = 192.168.60.1
local_interface = eth1
network_cidr = 192.168.60.0/24
masquerade_network = 192.168.60.0/24
dhcp_start = 192.168.60.5
dhcp_end = 192.168.60.50
inspection_iprange = 192.168.60.100,192.168.60.120
undercloud_debug = true
enable_telemetry = false
[auth]
[stack@director10 ~]$

Comment 1 Mike Orazi 2019-02-14 17:56:32 UTC
Gyan,

It looks like you are disabling validations on the initial install.  I adding needinfo on Lukas to see if it is possible/appropriate to -skip-tags ffwd-upgrade run step against an environment like this and if doing so would ignore the invocation to the validations package.

Comment 2 Lukas Bezdicka 2019-02-14 21:28:10 UTC
openstack-tripleo-validations should be installed and we depend on it - tripleo-ansible-inventory is provided by it

Comment 3 Gyanendra Kumar 2019-02-15 05:33:45 UTC
Thanks Lukas for confirming this that we need openstack-tripleo-validations  for FFU.


Can you please also provide your input on below query:

1. During initial undercloud installation if we don't enable the validation then can we install openstack-tripleo-validations package later. What is correct procedure to proceed for FFU in this case.

~~~
in Undercloud.conf:

enable_validations = false
~~~

2. Also I think we should mention in our documentation that this package is required.It took sometime for me to figure out how FFU depends on package openstack-tripleo-validations which generally installed during undercloud installation. There may be some customer who have not enabled validation (enable_validations = false) during undercloud installation and plan to do FFU.

Regards,
Gyan

Comment 9 Artem Hrechanychenko 2019-02-27 21:45:35 UTC
VERIFIED

(undercloud) [stack@undercloud-0 ~]$ rpm -qa python-tripleoclient
python-tripleoclient-9.2.6-8.el7ost.noarch


before UC installation

[stack@undercloud-0 ~]$ rpm -qa openstack-tripleo-validations
[stack@undercloud-0 ~]$ cat undercloud.conf
[DEFAULT]
Network interface on the Undercloud that will be handling the PXE
boots and DHCP for Overcloud instances. (string value)

local_interface = eth0
local_ip = 192.168.24.1/24
network_gateway = 192.168.24.1
undercloud_public_vip = 192.168.24.2
undercloud_admin_vip = 192.168.24.3
network_cidr = 192.168.24.0/24
masquerade_network = 192.168.24.0/24
dhcp_start = 192.168.24.5
dhcp_end = 192.168.24.24
inspection_iprange = 192.168.24.100,192.168.24.120
hieradata_override = /home/stack/hiera_override.yaml
TODO: use release >= 10 when RHBZ#1633193 is resolved

enable_validations = false

after UC installation
[stack@undercloud-0 ~]$ rpm -qa openstack-tripleo-validations
[stack@undercloud-0 ~]$ 



after upgrade UC 10 -> 13


[stack@undercloud-0 ~]$ rpm -qa --last |grep validations
openstack-tripleo-validations-8.4.4-2.el7ost.noarch Wed 27 Feb 2019 11:12:18 AM EST
[stack@undercloud-0 ~]$ date
Wed Feb 27 16:23:15 EST 2019
[stack@undercloud-0 ~]$ yum whatprovides openstack-tripleo-validations
Loaded plugins: product-id, search-disabled-repos, subscription-manager
rhelosp-13.0-optools-puddle 119/119
rhelosp-13.0-puddle 829/829
openstack-tripleo-validations-8.4.4-2.el7ost.noarch : Ansible playbooks to detect potential issues with TripleO deployments
Repo : rhelosp-13.0-puddle

openstack-tripleo-validations-8.4.4-2.el7ost.noarch : Ansible playbooks to detect potential issues with TripleO deployments
Repo : @rhelosp-13.0-puddle

Comment 11 errata-xmlrpc 2019-03-14 13:55:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0448


Note You need to log in before you can comment on or make changes to this bug.