The Fedoa CI findleaks test has been failing recently. Smoke and selftest pass. The failure is: ... 0:07:48 load avg: 0.67 [285/402] test_select 0:07:59 load avg: 0.56 [286/402] test_selectors ./findleaks.sh: line 18: 18881 Killed $PYTHON -m test -wW --findleaks $X Log: https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-rawhide-pr-pipeline/837/artifact/package-tests/logs/FAIL_str_findleaks.log This appears reproducible. Opening this to track it. Not sure if our test eat all memory or this is a CI issue :(
Context: the CI started to fail on my PR https://src.fedoraproject.org/rpms/python3/pull-request/92
I don't think this happens now. Reopen if it hits you.
This is back: https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-rawhide-pr-pipeline/1108/artifact/package-tests/logs/FAIL_str_findleaks.log
Still valid: https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-rawhide-pr-pipeline/detail/fedora-rawhide-pr-pipeline/1194/pipeline/
FTR this might be related to low amount of available memory. I'm trying to mitigate that via https://src.fedoraproject.org/rpms/python3/pull-request/107
Victor, you have provided some arguments against running findleaks privately. Can you please share them here?
regrtest --findleaks only logs extra warnings if gc.garbage is not empty, but the process still exit with a success (exit code 0) even if gc.garbage wasn't empty. For this reason, I don't think that it's useful to have a separated job to run tests using --findleaks, if tests are already run without --findleaks. --findleaks is useless, unless someone reads carefully logs manually, but I doubt anyone does that. I'm not sure if the Fedora CI has 2 jobs: one with --findleaks, one without. If it's the second, theone with --findleaks can be removed. I modified regrtest in Python 3.7 and 3.8 upstream to always enable --findleaks. If --fail-env-changed is used, a test is now considered as failed if gc.garbage was not empty. This option is enabled in all CI of Python upstream, and so any upstream now fail if gc.garbage is non-empty. * https://bugs.python.org/issue36719 * https://github.com/python/cpython/commit/75120d2205af086140e5e4e2dc620eb19cdf9078 Note: We added a fleet of Fedora buildbot workers on Python upstream. The Python test suite is now run upstream on Fedora Rawhide which is frequently updated automatically!
Let's get rid of findleaks in the CI. I'll do that.
A WIP PR for python3: https://src.fedoraproject.org/rpms/python3/pull-request/113