Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1678292

Summary:	Wrong openshift_ovirt_cluster in vars.yaml on bastion
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Jan Zmeskal <jzmeskal>
Component:	Generic	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ivana Saranova <isaranov>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	1.2.0.2	CC:	bugs, lleistne, sradco
Target Milestone:	ovirt-4.3.3	Flags:	sradco: ovirt-4.3? lleistne: testing_ack+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-16 13:58:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1631193

Description Jan Zmeskal 2019-02-18 12:54:44 UTC

Description of problem:
When you run
/usr/share/ovirt-engine-metrics/configure_ovirt_machines_for_metrics.sh --playbook=ovirt-metrics-store-installation.yml, vars.yaml file is created on bastion machine. 
Although I specified 
ovirt_cluster_name: <my_cluster> 
in /etc/ovirt-engine-metrics/config.yml.d/config.yml, in vars.yaml on the bastion it says:
openshift_ovirt_cluster: Default
This would most probably result in failure of metrics deployment, since I don't have a cluster called "Default" in my environment.

Version-Release number of selected component (if applicable):
ovirt-engine-metrics-1.2.1-0.0.master.20190217232716.el7.noarch.rpm (built from patch set 37 of https://gerrit.ovirt.org/#/c/97643/)

How reproducible:
100 %

Steps to Reproduce:
1. Use this config.yml: http://pastebin.test.redhat.com/716722
2. Run ovirt-metrics-store-installation.yml playbook
3. Check the content of vars.yaml on the bastion.

Actual results:
openshift_ovirt_cluster: Default

Expected results:
I would expect that openshift_ovirt_cluster would have the value I passed to ovirt_cluster_name in /etc/ovirt-engine-metrics/config.yml.d/config.yml.

Additional info:
- Log from ovirt-metrics-store-installation.yml is attached

Comment 2 Jan Zmeskal 2019-02-18 13:06:52 UTC

I found out the the wrong value of cluster is also present in 
 - openshift_ovirt_vm_profile (vars.yml)
 - template_cluster (vars.yml)
 - openshift_ovirt_cluster (integ.ini)

Comment 3 Jan Zmeskal 2019-02-19 12:25:14 UTC

Verified with ovirt-engine-metrics-1.2.1-0.0.master.20190219093951.el7.noarch

Comment 4 Sandro Bonazzola 2019-02-25 10:44:21 UTC

How can this bug be in verified state being the package not yet been built? Tag has not been yet created, referenced patch is not yet merged: https://gerrit.ovirt.org/#/c/97643/.

Moving back to ASSIGNED

Comment 5 Sandro Bonazzola 2019-02-25 10:44:43 UTC

Also bug is not targeted to any release.

Comment 6 Jan Zmeskal 2019-02-25 11:02:17 UTC

(In reply to Sandro Bonazzola from comment #4)
> How can this bug be in verified state being the package not yet been built?
> Tag has not been yet created, referenced patch is not yet merged:
> https://gerrit.ovirt.org/#/c/97643/.
> 
> Moving back to ASSIGNED

You're right, my mistake. I tested it from the latest gerrit patchset, but I shouldn't have moved it to verified.

Comment 7 Sandro Bonazzola 2019-03-12 12:53:47 UTC

4.3.1 has been released, please re-target this bug as soon as possible.

Comment 8 Ivana Saranova 2019-04-02 16:01:38 UTC

Steps:
1) set ovirt_cluster_name to cluster which is not Default
2) Run ovirt-metrics-store-installation.yml playbook

Results:
VM is created in correct cluster, playbook ends successfully.

Verified in: 
ovirt-engine-4.2.8.5-0.1.el7ev.noarch
ovirt-engine-metrics-1.2.1.3-1.el7ev.noarch

Also verified in:
ovirt-engine-4.3.3.1-0.1.el7.noarch
ovirt-engine-metrics-1.2.1.3-1.el7ev.noarch

Comment 9 Sandro Bonazzola 2019-04-16 13:58:12 UTC

This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.