Bug 1678372 - redeploy_certificates does not drain nodes and restart automatically docker
Summary: redeploy_certificates does not drain nodes and restart automatically docker
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.9.z
Assignee: Joseph Callen
QA Contact: Gaoyun Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-18 16:15 UTC by Gabriel Stein
Modified: 2019-07-05 06:59 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: When using crio docker was being restarted. Consequence: Docker-based pods are stopped during recertification Fix: Add a check to only restart docker when openshift_use_crio_only is false Result: Docker is not restarted if using cri-o
Clone Of:
Environment:
Last Closed: 2019-07-05 06:58:57 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:1642 0 None None None 2019-07-05 06:59:13 UTC

Comment 5 Gaoyun Pei 2019-04-19 06:44:20 UTC 
Tried the openshift-ansible/playbooks/redeploy-certificates.yml playbook with openshift-ansible-3.9.78-1


If I understand correctly, once we add openshift_node_restart_docker_required=False for openshift-node/private/restart.yml[1]
then docker service won't get restart in any cases during redeploy-certificates[2], is this expected?


Also, in https://github.com/openshift/openshift-ansible/blob/release-3.9/playbooks/openshift-node/private/restart.yml#L21
openshift_use_crio_only doesn't appear to have a default value, user may doesn't set openshift_use_crio_only var in ansible inventory file.


[1]https://github.com/openshift/openshift-ansible/blob/release-3.9/playbooks/redeploy-certificates.yml#L18
[2]https://github.com/openshift/openshift-ansible/blob/release-3.9/playbooks/openshift-node/private/restart.yml#L20
Comment 8 Joseph Callen 2019-04-23 12:36:35 UTC 
PR: https://github.com/openshift/openshift-ansible/pull/11538
Comment 9 Joseph Callen 2019-05-03 13:54:47 UTC 
build: openshift-ansible-3.9.80-1
Comment 13 Gaoyun Pei 2019-06-28 10:37:36 UTC 
Verify this bug with openshift-ansible-3.9.85-1.git.0.7c950b1.el7.noarch.rpm

When running playbooks/redeploy-certificates.yml to renew the certs, docker service will not be restarted.


PLAY [Restart nodes] ***********************************************************

TASK [Gathering Facts] *********************************************************
ok: [ec2-54-209-35-240.compute-1.amazonaws.com]

TASK [Mark node unschedulable] *************************************************
skipping: [ec2-54-209-35-240.compute-1.amazonaws.com] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}

TASK [Drain Node for Kubelet restart] ******************************************
skipping: [ec2-54-209-35-240.compute-1.amazonaws.com] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}

TASK [Restart docker] **********************************************************
skipping: [ec2-54-209-35-240.compute-1.amazonaws.com] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}
Comment 15 errata-xmlrpc 2019-07-05 06:58:57 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1642
Note You need to log in before you can comment on or make changes to this bug.