New commits detected on ManageIQ/manageiq/hammer:
Author: Greg McCullough <firstname.lastname@example.org>
AuthorDate: Mon Feb 11 12:04:57 2019 -0500
Commit: Greg McCullough <email@example.com>
CommitDate: Mon Feb 11 12:04:57 2019 -0500
Merge pull request #18443 from d-m-u/remove_lbs_from_retirement_check
Don't retire load balancers
(cherry picked from commit d8a6ba00be00d215a44af0f71e27f7ad364967ba)
app/models/load_balancer.rb | 1 -
app/models/retirement_manager.rb | 2 +-
spec/models/retirement_manager_spec.rb | 4 +-
3 files changed, 2 insertions(+), 5 deletions(-)
Author: Brandon Dunne <firstname.lastname@example.org>
AuthorDate: Mon Feb 18 15:38:18 2019 -0500
Commit: Brandon Dunne <email@example.com>
CommitDate: Mon Feb 18 15:38:18 2019 -0500
Merge pull request #18437 from d-m-u/adding_user_existence_check
Add check for existence of user for system_context
(cherry picked from commit 265774dd3ab68ae26f117e2cca073003cb5066d3)
app/models/mixins/retirement_mixin.rb | 10 +-
spec/models/orchestration_stack/retirement_management_spec.rb | 43 +-
spec/models/service/retirement_management_spec.rb | 63 +-
spec/models/vm/retirement_management_spec.rb | 46 +-
4 files changed, 107 insertions(+), 55 deletions(-)
*** Bug 1678474 has been marked as a duplicate of this bug. ***
Reverted the backport of https://github.com/ManageIQ/manageiq/pull/18443 and https://github.com/ManageIQ/manageiq/pull/18437
Hey you wonderful people, I can't close this bug because the PR in comment 4 hasn't been merged. It'd be super great to get the target release set and get this puppy merged cause it's a couple months old now and I'd really like to close this ticket.
Hey Gellert, I get that this ticket is associated with the one about the valid retirement date (https://bugzilla.redhat.com/show_bug.cgi?id=1697524) because they both involve the same error, but I think that comment 6 should be on the other ticket since this isn't about a retirement date at all. I think the other bug probably needs the PR that fixes this and it will then need to be retested to make sure there's nothing else wrong with it.
create a service with a user that isn't admin
provision the service
delete the user from the db
schedule the service to retire more than fifteen minutes from now
check to see who the requester for the retirement shows up as
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.