Red Hat Bugzilla – Bug 167863
Review Request: gpp - gnome-photo-printer
Last modified: 2007-11-30 17:11:13 EST
Spec Name or Url: http://domsch.com/linux/fedora/extras/gpp/gpp.spec
SRPM Name or Url: http://domsch.com/linux/fedora/extras/gpp/gpp-0.6.5-1.fc4.src.rpm
Gnome Photo Printer is intended for printing photos in an easy way.
Just drag your Photos from Nautilus to the Gnome Photo Printer window
and drop it. Make some selections like Photo or Paper size, hit Preview
or Print , and see your pictures printed.
- in the description there are a few too many spaces, e.g., "or Print ,"
- in the desktop file, use printer.png instead of full path; better yet would
be a new icon, because the printer.png icon is pretty generic; maybe
you concoct something from a printer icon and a photo icon
- in the desktop file, name should be "Gnome Photo Printer" or simply
"Photo Printer" or simply "Print Photos"; I prefer the second, so
there is no issue with "Gnome" and "GNOME" :-)
- in the desktop file, why is StartupNotify false? it seems to work with true
- rpmlint is completely satisfied
Thanks for the review. I fixed the description (the extra spaces are present in
the original package's description), removed the full path to printer.png,
changed .desktop Name="Photo Printer" and StartupNotify=true. New RPMs and spec
posted to the same location.
I did not create a new icon, as *any* existing icon would be better than what I
could create myself. If someone wishes to create an icon for this package, I'll
be happy to add it later.
The example .desktop file in http://fedoraproject.org/wiki/PackagingGuidelines
has StartupNotify=false. Perhaps this should be changed?
(In reply to comment #2)
> The example .desktop file in http://fedoraproject.org/wiki/PackagingGuidelines
> has StartupNotify=false. Perhaps this should be changed?
This is a safe default. For regular GNOME apps StartupNotify=true works.
For KDE apps I don't know.
Committed to cvs and building now for FC3 and FC4. Closing.