Bug 1678670 - FreeIPA FTBS due to talloc_stack.h missing from samba-devel
Summary: FreeIPA FTBS due to talloc_stack.h missing from samba-devel
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: freeipa
Version: rawhide
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
Assignee: François Cami
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1677027 1678793
TreeView+ depends on / blocked
 
Reported: 2019-02-19 11:11 UTC by François Cami
Modified: 2019-02-19 15:44 UTC (History)
17 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-19 15:18:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description François Cami 2019-02-19 11:11:47 UTC
Description of problem:
The file
https://github.com/samba-team/samba/blob/master/lib/util/talloc_stack.h
seems to be missing from samba-devel 
leading to FTBFS for FreeIPA:
https://kojipkgs.fedoraproject.org//work/tasks/4059/32904059/build.log

/bin/sh ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..  -I. -I../../asn1 -I/usr/include/samba-4.0 -DPREFIX=\""/usr"\" -DBINDIR=\""/usr/bin"\" -DLIBDIR=\""/usr/lib64"\" -DLIBEXECDIR=\""/usr/libexec"\" -DDATADIR=\""/usr/share"\" -DLDAPIDIR=\""/var/run"\" -DHAVE_LDAP -I../../util      -I/usr/include/samba-4.0 -DHAVE_IMMEDIATE_STRUCTURES=1  -I/usr/include/samba-4.0 -D_GNU_SOURCE=1 -DHAVE_IMMEDIATE_STRUCTURES=1    -I/usr/include/nspr4  -I/usr/include/nss3 -I/usr/include/nspr4   -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align -Werror-implicit-function-declaration  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D__STDC_WANT_LIB_EXT1__=1 -D_DEFAULT_SOURCE=1 -D_POSIX_C_SOURCE=200809L -Werror=implicit-function-declaration -c -o ipa_sam.lo ipa_sam.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I. -I../../asn1 -I/usr/include/samba-4.0 -DPREFIX=\"/usr\" -DBINDIR=\"/usr/bin\" -DLIBDIR=\"/usr/lib64\" -DLIBEXECDIR=\"/usr/libexec\" -DDATADIR=\"/usr/share\" -DLDAPIDIR=\"/var/run\" -DHAVE_LDAP -I../../util -I/usr/include/samba-4.0 -DHAVE_IMMEDIATE_STRUCTURES=1 -I/usr/include/samba-4.0 -D_GNU_SOURCE=1 -DHAVE_IMMEDIATE_STRUCTURES=1 -I/usr/include/nspr4 -I/usr/include/nss3 -I/usr/include/nspr4 -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align -Werror-implicit-function-declaration -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D__STDC_WANT_LIB_EXT1__=1 -D_DEFAULT_SOURCE=1 -D_POSIX_C_SOURCE=200809L -Werror=implicit-function-declaration -c ipa_sam.c  -fPIC -DPIC -o .libs/ipa_sam.o
BUILDSTDERR: ipa_sam.c:22:10: fatal error: util/talloc_stack.h: No such file or directory
BUILDSTDERR:    22 | #include <util/talloc_stack.h>



Version-Release number of selected component (if applicable):
2:4.10.0-0.2.rc2.fc30.1 

How reproducible:
Always

Steps to Reproduce:
1. Rebuild freeipa-4.7.2-4.fc30 or similar

Actual results:
Build fails


Expected results:
Build succeeds

Comment 1 François Cami 2019-02-19 13:42:57 UTC
As the Samba change is intended, re-assigning to FreeIPA.

Upstream PR: https://github.com/freeipa/freeipa/pull/2846

Comment 2 François Cami 2019-02-19 15:07:03 UTC
Fixed upstream
master: https://github.com/freeipa/freeipa/commit/d1f5ed64e16d65b9df45cc0eac7d2724dcae7b67

Comment 3 François Cami 2019-02-19 15:18:50 UTC
Built for rawhide with Sumit's patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=32907535
Closing.


Note You need to log in before you can comment on or make changes to this bug.