Bug 1679484 - Use a better icon for RHEL 7+ guests
Summary: Use a better icon for RHEL 7+ guests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libguestfs
Version: 8.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: 8.0
Assignee: Pino Toscano
QA Contact: YongkuiGuo
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-21 08:45 UTC by Pino Toscano
Modified: 2020-11-14 05:56 UTC (History)
9 users (show)

Fixed In Version: libguestfs-1.40.2-2.module+el8.0.1+2990+fb52aff8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1679483
Environment:
Last Closed: 2019-08-07 10:41:10 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:2395 0 None None None 2019-08-07 10:41:22 UTC

Description Pino Toscano 2019-02-21 08:45:42 UTC
+++ This bug was initially created as a clone of Bug #1679483 +++

+++ This bug was initially created as a clone of Bug #1679482 +++

Description of problem:
When extracting the icon of RHEL 7 and greater (using the inspect_get_icon API), libguestfs uses the file: /usr/share/pixmaps/fedora-logo-sprite.png.
It turned out that this file is not a good choice, as (especially starting with RHEL 8) it is not a proper "logo", but more like a banner.

After talking with Ray Strode (who maintains redhat-logos), the better option for this is to use one of the system-logo-icon.png icons in the hicolor icon theme, for example:
/usr/share/icons/hicolor/96x96/apps/system-logo-icon.png

Steps to Reproduce:
1. get the icon of a RHEL 7 guest, for example using virt-inspector, or in virt-manager (after installing python-libguestfs)
2. look at the icon

Actual results:
- in RHEL 7 guests, it is a shadowman
- in RHEL 8 guests, it is a RHEL "banner"

Expected results:
- the same shadowman in RHEL 7 & 8

Additional info:
Patch proposed upstream for this:
https://www.redhat.com/archives/libguestfs/2019-February/msg00025.html

Comment 2 Pino Toscano 2019-04-10 10:02:18 UTC
Fixed upstream with
https://github.com/libguestfs/libguestfs/commit/c648052690a4a07a59c741308e0e8497d6f18057
which is in libguestfs >= 1.41.1.

Comment 4 YongkuiGuo 2019-04-30 12:34:23 UTC
Verified with package:
libguestfs-1.40.2-2.module+el8.0.1+2990+fb52aff8.x86_64

Steps:

1. On rhel8.0 host
# virt-inspector -a rhel7.6.raw | virt-inspector --xpath 'string(//icon)' | base64 -i -d | display -
# virt-inspector -a rhel8.0.raw | virt-inspector --xpath 'string(//icon)' | base64 -i -d | display -

Both are the shadowman. Verified this bug.

Comment 6 errata-xmlrpc 2019-08-07 10:41:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2395


Note You need to log in before you can comment on or make changes to this bug.