Bug 1679727 - SnappyConfig.cmake installed in wrong location
Summary: SnappyConfig.cmake installed in wrong location
Alias: None
Product: Fedora
Classification: Fedora
Component: snappy
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Martin Gieseking
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2019-02-21 17:57 UTC by Uwe L. Korn
Modified: 2019-03-01 02:38 UTC (History)
1 user (show)

Fixed In Version: snappy-1.1.7-8.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-03-01 02:38:34 UTC
Type: Bug

Attachments (Terms of Use)

Description Uwe L. Korn 2019-02-21 17:57:08 UTC
The generated CMake configurations for Snappy (SnappyConfig.cmake and SnappyTargets.cmake) are installed in the wrong location. They are explicitly moved to `%{_datadir}/cmake/Modules/` while the actual Snappy installation installs them since 1.1.7 into the correct location (%{_libdir}/cmake/Snappy). The `Modules` folder is only meant for the `FindSnappy.cmake` module (which is not needed as SnappyConfig.cmake provides a more modern replacement).

This can be fixed by removing the following two lines from the package spec:

mkdir -p %{buildroot}%{_datadir}/cmake/Modules/
mv %{buildroot}%{_libdir}/cmake/Snappy/*cmake %{buildroot}%{_datadir}/cmake/Modules/

Comment 1 Martin Gieseking 2019-02-24 08:46:15 UTC
Thanks for the issue report. Would you like to update your pull request [1] according to the comment so that it can be merged? Otherwise, I'll close it and commit a separate patch.

[1] https://src.fedoraproject.org/rpms/snappy/pull-request/1

Comment 2 Uwe L. Korn 2019-02-24 11:13:06 UTC
I would prefer when you could take over the issue. As I'm neither a Fedora developer nor user, I'm quite unexperienced in building RPMs. I just came across this problem while debugging a problem of a user of my project (Apache Arrow).

Comment 3 Martin Gieseking 2019-02-25 09:51:42 UTC
OK, no problem. I've committed the changes and started the rebuilds.

Comment 4 Fedora Update System 2019-02-25 10:25:33 UTC
snappy-1.1.7-8.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-02e2f776df

Comment 5 Fedora Update System 2019-02-26 04:10:59 UTC
snappy-1.1.7-8.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-02e2f776df

Comment 6 Fedora Update System 2019-03-01 02:38:34 UTC
snappy-1.1.7-8.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.