Bug 1680302 - Review Request: rust-sha-1 - SHA-1 hash function
Summary: Review Request: rust-sha-1 - SHA-1 hash function
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-23 18:18 UTC by Randy Barlow
Modified: 2019-02-25 16:41 UTC (History)
2 users (show)

Fixed In Version: rust-sha-1-0.8.1-1.fc31
Clone Of:
Environment:
Last Closed: 2019-02-25 16:41:24 UTC
Type: ---
Embargoed:
igor.raits: fedora-review+


Attachments (Terms of Use)

Description Randy Barlow 2019-02-23 18:18:48 UTC
Spec URL: https://bowlofeggs.fedorapeople.org/rust-sha-1.spec
SRPM URL: https://bowlofeggs.fedorapeople.org/rust-sha-1-0.8.1-1.fc30.src.rpm
Description: SHA-1 hash function
Fedora Account System Username: bowlofeggs

Comment 1 Igor Raits 2019-02-23 18:39:44 UTC
> # Initial patched metadata
Please put some comment what is being patched. something like:
# * sha-1-asm is x86-specific

> %global _description \
> SHA-1 hash function
Add fullstop here.

> %files          devel
License and readme stuff is missing here.

Comment 2 Randy Barlow 2019-02-23 18:49:03 UTC
Hey Igor!

I fixed the things you mentioned above, except for the readme, because it is not included in the crate. There seems to be a single GitHub repo that generates a group of crates, and the top level of the repo does have a readme, but the individual crate dirs do not. If you want, I could pull down the top level readme as Source1, but I've not done that in the current version.

I used the same URLs as above.

Comment 4 Gwyn Ciesla 2019-02-25 15:03:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sha-1

Comment 5 Randy Barlow 2019-02-25 16:41:24 UTC
Thanks Igor!

I even remembered to add the rust-sig for you!


Note You need to log in before you can comment on or make changes to this bug.