Description: HTTP::Tiny::Multipart Perl module. Issues: fedora-review shows no obvious issues. rpmlint is silent. FAS-User: besser82 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart-0.08-0.1.fc31.src.rpm Thanks for review in advance!
Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33005538
=== Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.08-0.2 - Add missing BuildRequires: perl(Test::More) Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart-0.08-0.2.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33005623
=== Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.08-0.3 - Added explicit perl module compat requires Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33006255
Are you interested in a review swap? Maybe take a look into bug #1469767.
> %{perl_vendorlib}/* > %{_mandir}/man3/* Please add %{name} macro somehow. We've this policy in Python, no idea if it's relevant for Perl as well. You'd be automatically notified in a new build run when there are any new files in another release bump of future upstream. All in all, your spec file looks good. I'll run fedora-review tool asap.
Unassigning reviewer, resetting status to NEW.
- CONTRIBUTORS should be in %doc not %license URL and Source addresses are Ok. Source archive (SHA-256: ed0d43d470797c236be7f83e414e31561560ef3f88fab1ec09def20d98c361d6) is original. Ok. Summary verified from lib/HTTP/Tiny/Multipart.pm. → Use: "Add post_multipart to HTTP::Tiny" Description verified from lib/HTTP/Tiny/Multipart.pm. → Use: "Add post_multipart to HTTP::Tiny" License verified from lib/HTTP/Tiny/Multipart.pm and LICENSE. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-HTTP-Tiny-Multipart.spec review-perl-HTTP-Tiny-Multipart/results/perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm review-perl-HTTP-Tiny-Multipart/results/perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/doc/perl-HTTP-Tiny-Multipart -rw-r--r-- 1 root root 1550 avril 30 2018 /usr/share/doc/perl-HTTP-Tiny-Multipart/Changes drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/licenses/perl-HTTP-Tiny-Multipart -rw-r--r-- 1 root root 389 avril 30 2018 /usr/share/licenses/perl-HTTP-Tiny-Multipart/CONTRIBUTORS -rw-r--r-- 1 root root 9042 avril 30 2018 /usr/share/licenses/perl-HTTP-Tiny-Multipart/LICENSE -rw-r--r-- 1 root root 1730 févr. 24 18:07 /usr/share/man/man3/HTTP::Tiny::Multipart.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/perl5/vendor_perl/HTTP drwxr-xr-x 2 root root 0 févr. 24 18:07 /usr/share/perl5/vendor_perl/HTTP/Tiny -rw-r--r-- 1 root root 5136 avril 30 2018 /usr/share/perl5/vendor_perl/HTTP/Tiny/Multipart.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Carp) 1 perl(File::Basename) 1 perl(HTTP::Tiny) 1 perl(MIME::Base64) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Add all BR for tests: BuildRequires: perl(HTTP::Tiny::Multipart) BuildRequires: perl(Test::Pod) >= 1.41 BuildRequires: perl(Test::Pod::Coverage) >= 1.08 BuildRequires: perl(Pod::Coverage::TrustPod) $ rpm -q --provides -p perl-HTTP-Tiny-Multipart-0.08-0.3.fc31.noarch.rpm perl(HTTP::Tiny::Multipart) = 0.08 perl-HTTP-Tiny-Multipart = 0.08-0.3.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33012716). Ok Resolution: Package not approved. Please fix all the aforementioned points.
Sorry, don't add BuildRequires: perl(HTTP::Tiny::Multipart)
(In reply to Robert-André Mauchin from comment #7) > - CONTRIBUTORS should be in %doc not %license I think the list of the contributors (and thus the copyright holders) are a part of the actual license. Your other remarks have been addressed. *** === Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.08-0.4 - Changes as suggested in review (#1680373) - Add a set of explicit BuildRequires - Improve Summary tag and %%description Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-HTTP-Tiny-Multipart-0.08-0.4.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33013042
> I think the list of the contributors (and thus the copyright holders) are a part of the actual license. I'm sure it is not. AUTHORS and CONTRIBUTORS files all go to %doc. Only LICENSE and PATENTS files go to %license. Package approved otherwise.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTTP-Tiny-Multipart
perl-GitLab-API-v4-0.17-1.fc29 perl-HTTP-Tiny-Multipart-0.08-1.fc29 perl-IO-Prompter-0.004015-1.fc29 perl-Log-Any-Adapter-Screen-0.140-1.fc29 perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f
devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050
devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050
perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f
perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.