Description: IO::Prompter exports a single subroutine, prompt, that prints a prompt (but only if the program's selected input and output streams are connected to a terminal), then reads some input, then chomps it, and finally returns an object representing that text. Issues: fedora-review shows no obvious issues. rpmlint is silent. FAS-User: besser82 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter-0.004015-0.1.fc31.src.rpm Thanks for review in advance!
Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33005541
=== Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.004015-0.2 - Added explicit perl module compat requires Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter-0.004015-0.2.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33006258
- %{__perl} → perl - Use: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 with perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 And thus remove: %{_bindir}/find %{buildroot} -type f -name .packlist -exec rm -f {} \; %{_bindir}/find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; - Use NO_PERLLOCAL=1: perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 with %make_install instead of %{__make} pure_install PERL_INSTALL_ROOT=%{buildroot} - Do not package META.json im %files - Add a BR for Perl required version: BuildRequires: perl(:VERSION) >= 5.010 URL and Source addresses are Ok. Source archive (SHA-256: 173192b3989b1e47e606ce9ba2cacc1da3d07de216002931288318eecf8e3ffb) is original. Ok. Summary verified from lib/IO/Prompter.pm. Ok. Description verified from lib/IO/Prompter.pm. Ok. License verified from lib/IO/Prompter.pm and README. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-IO-Prompter.spec review-perl-IO-Prompter/results/perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm review-perl-IO-Prompter/results/perl-IO-Prompter-0.004015-0.2.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm drwxr-xr-x 2 root root 0 févr. 24 15:33 /usr/share/doc/perl-IO-Prompter -rw-r--r-- 1 root root 4474 déc. 7 20:53 /usr/share/doc/perl-IO-Prompter/Changes -rw-r--r-- 1 root root 936 déc. 7 20:53 /usr/share/doc/perl-IO-Prompter/META.json -rw-r--r-- 1 root root 1042 déc. 7 20:53 /usr/share/doc/perl-IO-Prompter/README -rw-r--r-- 1 root root 22712 févr. 24 15:33 /usr/share/man/man3/IO::Prompter.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 15:33 /usr/share/perl5/vendor_perl/IO -rw-r--r-- 1 root root 123312 déc. 7 20:53 /usr/share/perl5/vendor_perl/IO/Prompter.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.10.0 1 perl(Carp) 1 perl(Contextual::Return) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Symbol) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Add these as BR too: BuildRequires: perl(Carp) BuildRequires: perl(Scalar::Util) BuildRequires: perl(strict) BuildRequires: perl(Symbol) BuildRequires: perl(utf8) BuildRequires: perl(warnings) # Tests BuildRequires: perl(diagnostics) BuildRequires: perl(lib) $ rpm -q --provides -p perl-IO-Prompter-0.004015-0.2.fc31.noarch.rpm perl(IO::Prompter) = 0.004015 perl-IO-Prompter = 0.004015-0.2.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33010164). Ok Resolution: Package not approved. Please fix all the aforementioned points.
Thank you for the review! (In reply to Robert-André Mauchin from comment #3) > - %{__perl} → perl I think that is a matter of personal preference. Your other remarks have been addressed. *** === Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.004015-0.2 - Changes as suggested in review (#1680374) - Add a BR for Perl required version - Add a set of explicit BuildRequires - Use %%make_install - Drop cleanups using find - Drop META.json fom %%doc Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter-0.004015-0.3.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33010978
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IO-Prompter
perl-GitLab-API-v4-0.17-1.fc29 perl-HTTP-Tiny-Multipart-0.08-1.fc29 perl-IO-Prompter-0.004015-1.fc29 perl-Log-Any-Adapter-Screen-0.140-1.fc29 perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f
devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050
devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050
perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f
perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.