Description: This Log::Any adapter prints log messages to screen (STDERR/STDOUT). The messages are colored according to level (unless coloring is turned off). It has a few other features: allow passing formatter, allow setting level from some environment variables, add prefix/timestamps. Issues: fedora-review shows no obvious issues. rpmlint is silent. FAS-User: besser82 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-Screen.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-Screen-0.140-0.1.fc31.src.rpm Thanks for review in advance!
Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33005543
=== Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.140-0.2 - Added explicit perl module compat requires Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-Screen.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33006261
Unassigning reviewer, resetting status to NEW.
URL and Source addresses are Ok. Source archive (SHA-256: 992bf35d49684bbdc69c9c84bb7088e57c878b812bc42e631bd2697e1ab088ae) is original. Ok. Summary verified from lib/Log/Any/Adapter/Screen.pm. Ok. Description verified from lib/Log/Any/Adapter/Screen.pm. Ok. License verified from lib/Log/Any/Adapter/Screen.pm and README. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-Log-Any-Adapter-Screen.spec review-perl-Log-Any-Adapter-Screen/results/perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm review-perl-Log-Any-Adapter-Screen/results/perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.src.rpm perl-Log-Any-Adapter-Screen.noarch: W: spelling-error %description -l en_US formatter -> formatted, for matter, for-matter perl-Log-Any-Adapter-Screen.noarch: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps perl-Log-Any-Adapter-Screen.src: W: spelling-error %description -l en_US formatter -> formatted, for matter, for-matter perl-Log-Any-Adapter-Screen.src: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps 2 packages and 1 specfiles checked; 0 errors, 4 warnings. $ rpm -q -lv -p perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm 18:21:59 drwxr-xr-x 2 root root 0 févr. 24 18:18 /usr/share/doc/perl-Log-Any-Adapter-Screen -rw-r--r-- 1 root root 2028 déc. 22 01:57 /usr/share/doc/perl-Log-Any-Adapter-Screen/Changes -rw-r--r-- 1 root root 5006 déc. 22 01:57 /usr/share/doc/perl-Log-Any-Adapter-Screen/README drwxr-xr-x 2 root root 0 févr. 24 18:18 /usr/share/licenses/perl-Log-Any-Adapter-Screen -rw-r--r-- 1 root root 18457 déc. 22 01:57 /usr/share/licenses/perl-Log-Any-Adapter-Screen/LICENSE -rw-r--r-- 1 root root 3262 févr. 24 18:18 /usr/share/man/man3/Log::Any::Adapter::Screen.3pm.gz drwxr-xr-x 2 root root 0 févr. 24 18:18 /usr/share/perl5/vendor_perl/Log drwxr-xr-x 2 root root 0 févr. 24 18:18 /usr/share/perl5/vendor_perl/Log/Any drwxr-xr-x 2 root root 0 févr. 24 18:18 /usr/share/perl5/vendor_perl/Log/Any/Adapter -rw-r--r-- 1 root root 8608 déc. 22 01:57 /usr/share/perl5/vendor_perl/Log/Any/Adapter/Screen.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm | sort -f | uniq -c 18:22:44 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.10.1 1 perl(Log::Any) 1 perl(Log::Any::Adapter::Base) 1 perl(Log::Any::Adapter::Util) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. - Add BR for BuildRequires: perl(Log::Any::Adapter::Base) # Tests BuildRequires: perl(Test::Perl::Critic) BuildRequires: perl(Test::Pod) >= 1.41 BuildRequires: perl(Test::Pod::Coverage) >= 1.08 BuildRequires: perl(Pod::Coverage::TrustPod) $ rpm -q --provides -p perl-Log-Any-Adapter-Screen-0.140-0.2.fc31.noarch.rpm 18:30:51 perl(Log::Any::Adapter::Screen) = 0.140 perl-Log-Any-Adapter-Screen = 0.140-0.2.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33012894). Ok Resolution: Package not approved. Please fix all the aforementioned points.
Your remarks have been addressed. *** === Updated package === Changelog: * Sun Feb 24 2019 Björn Esser <besser82> - 0.140-0.3 - Changes as suggested in review (#1680375) - Add a set of explicit BuildRequires Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-Screen.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/perl-Log-Any-Adapter-Screen-0.140-0.3.fc31.src.rpm Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=33013201
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Log-Any-Adapter-Screen
perl-GitLab-API-v4-0.17-1.fc29 perl-HTTP-Tiny-Multipart-0.08-1.fc29 perl-IO-Prompter-0.004015-1.fc29 perl-Log-Any-Adapter-Screen-0.140-1.fc29 perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f
devscripts-2.19.2-3.fc28 perl-GitLab-API-v4-0.17-1.fc28 perl-HTTP-Tiny-Multipart-0.08-1.fc28 perl-IO-Prompter-0.004015-1.fc28 perl-Log-Any-Adapter-Screen-0.140-1.fc28 perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050
devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7990f2a050
perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-43303fad7f
perl-GitLab-API-v4-0.17-1.fc29, perl-HTTP-Tiny-Multipart-0.08-1.fc29, perl-IO-Prompter-0.004015-1.fc29, perl-Log-Any-Adapter-Screen-0.140-1.fc29, perl-Log-Any-Adapter-TAP-0.003003-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
devscripts-2.19.2-3.fc28, perl-GitLab-API-v4-0.17-1.fc28, perl-HTTP-Tiny-Multipart-0.08-1.fc28, perl-IO-Prompter-0.004015-1.fc28, perl-Log-Any-Adapter-Screen-0.140-1.fc28, perl-Log-Any-Adapter-TAP-0.003003-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.