Description of problem:

If a log file entry is inadvertently duplicated among config files in /etc/logrotate.d , logrotate fails (doesn't rotate any log files), but still returns zero return code, so there's no notification of the issue. This leads to log files not getting rotated, growing to fill the filesystem.

/etc/cron.daily/logrotate specifically looks for a non-zero return code from the logrotate command it runs in order to alert about an issue. Because a config duplication error returns 0, no alert is logged.

# /usr/sbin/logrotate -s /var/lib/logrotate/logrotate.status /etc/logrotate.conf
error: syslog:1 duplicate log entry for /var/log/boot.log
# echo $?
0
#

Version-Release number of selected component (if applicable):
logrotate-3.8.6-17.el7.x86_64

How reproducible:

Always, when a duplicate log file entry is present. Main issue is if duplicate entry is in /etc/logrotate.d/syslog (and there is already another, separate config file for that logfile), files in the syslog config file don't get rolled.

Steps to Reproduce:
 if  /etc/logrotate.d/bootlog   exists and looks like :
/var/log/boot.log
{
    missingok
    daily
    copytruncate
    rotate 7
    notifempty
}

And your /etc/logrotate.d/syslog looks like this :

/var/log/boot.log
{
    missingok
    daily
    copytruncate
    rotate 7
    notifempty
}

You will get the "error: syslog:1 duplicate log entry for /var/log/boot.log" and none of the additional files listed in /etc/logrotate.d/syslog will get rotated. And because it returns 0, /etc/cron.daily/logrotate won't log the error.

Actual results:
# /usr/sbin/logrotate -s /var/lib/logrotate/logrotate.status /etc/logrotate.conf
error: syslog:1 duplicate log entry for /var/log/boot.log
# echo $?
0
#


Expected results:
# /usr/sbin/logrotate -s /var/lib/logrotate/logrotate.status /etc/logrotate.conf
error: syslog:1 duplicate log entry for /var/log/boot.log
# echo $?
1
#