Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Locale-Maketext-Lexicon.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Locale-Maketext-Lexicon-0.49-1.src.rpm Description: Locale::Maketext::Lexicon provides lexicon-handling backends for Locale::Maketext to read from other localization formats, such as PO files, MO files, or from databases via the "Tie" interface.
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec, not in separate file - spec file written in English and is legible - sources match upstream - package builds OK on FC4 and in mock for rawhide (i386) - no explicit BR's - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop file needed - no scriptlets - provides-filtering script is necessary (provided) Notes: - URL for Source0 doesn't work: s/www/search/ - Does CVS preserve exec permissions on source files? If not, then %define __perl_provides %{SOURCE1} won't work reliably out of CVS because %{SOURCE1} may not have exec permission. I'd advocate adding: chmod 755 %{SOURCE1} to the end of %prep as a safeguard Approved.
(In reply to comment #1) > - URL for Source0 doesn't work: s/www/search/ Grumble ... I somehow screwed my template. > - Does CVS preserve exec permissions on source files? It does - Actually, not taking this into account during check-in into CVS is a fairly common mistake in using CVS (Changing permissions requires admin intervention on the files inside of CVS). But I am not sure about the side-effects of cvs-import :) > Approved. Thanks.
New Package SCM Request ====================== Package Name: perl-Locale-Maketext-Lexicon New Branches: epel7 Owners: richardhenwood The Fedora maintainer (Ralf Corsepius, corsepiu) does not support EPEL7.
ARNING: "richardhenwood" is not in the packager group. WARNING: No description provided. WARNING: fedora-review flag not set Also, use a Package Change request for a new branch.