Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1683119

Summary: [RHEL7] nvme-cli: print "\n" after nvme list-subsys -o json
Product: Red Hat Enterprise Linux 7 Reporter: Zhang Yi <yizhan>
Component: nvme-cliAssignee: gopal krishna tiwari <gtiwari>
Status: CLOSED WONTFIX QA Contact: Zhang Yi <yizhan>
Severity: low Docs Contact:
Priority: low    
Version: 7.6CC: nyewale, yizhan
Target Milestone: rc   
Target Release: 7.7   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1683122 (view as bug list) Environment:
Last Closed: 2021-03-15 07:33:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1683122    

Description Zhang Yi 2019-02-26 09:48:36 UTC
Description of problem:
nvme-cli: print "\n" after nvme list-subsys -o json

Version-Release number of selected component (if applicable):

How reproducible:
100%

Steps to Reproduce:
[root@storageqe-62 ~]# nvme list-subsys
nvme-subsys0 - NQN=nqn.2014.08.org.nvmexpress:144d1028      S2JRNA0J300174Dell Express Flash NVMe PM1725 800GB SFF
\
 +- nvme0 pcie 0000:85:00.0
[root@storageqe-62 ~]# nvme list-subsys -o json
{
  "Subsystems" : [
    {
      "Name" : "nvme-subsys0",
      "NQN" : "nqn.2014.08.org.nvmexpress:144d1028      S2JRNA0J300174Dell Express Flash NVMe PM1725 800GB SFF"
    },
    {
      "Paths" : [
        {
          "Name" : "nvme0",
          "Transport" : "pcie",
          "Address" : "0000:85:00.0"
        }
      ]
    }
  ]
}[root@storageqe-62 ~]# 

Actual results:


Expected results:


Additional info:

Here is the patch, and merged in upstream v1.7
[yizhan@dhcp-12-135 nvme-cli]$ git tag --contains bef7a2bfafdfff9309bfa0b80ea04808f3356078
v1.7

[yizhan@dhcp-12-135 nvme-cli]$ git log -p bef7a2bfafdfff9309bfa0b80ea04808f3356078
commit bef7a2bfafdfff9309bfa0b80ea04808f3356078
Author: Yi Zhang <yi.zhang>
Date:   Thu Sep 20 19:41:57 2018 +0800

    nvme-cli: print "\n" after nvme list-subsys -o json
    
    Signed-off-by: Yi Zhang <yi.zhang>

diff --git a/nvme-print.c b/nvme-print.c
index 17b5eaf..df7df4d 100644
--- a/nvme-print.c
+++ b/nvme-print.c
@@ -2823,6 +2823,7 @@ void json_print_nvme_subsystem_list(struct subsys_list_item *slist, int n)
        if (i)
                json_object_add_value_array(root, "Subsystems", subsystems);
        json_print_object(root, NULL);
+       printf("\n");
 }
 
 static void show_registers_cap(struct nvme_bar_cap *cap)

Comment 2 David Milburn 2019-02-26 13:09:31 UTC
Thanks Yi, I plan on updating RHEL7.7 to v1.7. Would please
check the state of bug 1489965 and bug 1520994 and see if
they are fixed in v1.7 or earlier? Thanks.

Comment 4 Zhang Yi 2019-05-07 11:14:59 UTC
Verified with nvme-cli-1.8.1, move to VERIFIED.

Thanks
Yi

Comment 9 RHEL Program Management 2021-03-15 07:33:35 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.