Bug 1683605 - config.yml.example should reference ovirt_template_disk_storage variable
Summary: config.yml.example should reference ovirt_template_disk_storage variable
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.2.0.2
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.3.3
: ---
Assignee: Shirly Radco
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks: 1631193
TreeView+ depends on / blocked
 
Reported: 2019-02-27 10:43 UTC by Jan Zmeskal
Modified: 2019-04-04 13:17 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-04-04 12:56:42 UTC
oVirt Team: Metrics
Embargoed:
sradco: ovirt-4.3?
lleistne: testing_ack+


Attachments (Terms of Use)

Description Jan Zmeskal 2019-02-27 10:43:27 UTC
Description of problem:
In /etc/ovirt-engine-metrics/config.yml.example we prompt user to override the default value ("hosted-storage") for openshift_ovirt_storage_domain_name. However, if they do that, they might experience storage domain mismatch described in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1679521
Therefore the exapmle config file should mention, that if user wants to override that value, they should also override the value of variable `ovirt_template_disk_storage`. It's definitely not apparent, because default value for those two variables are set in two different places. 

Default for `openshift_ovirt_storage_domain_name` is set in templates/vars.yaml.template, while the default for `ovirt_template_disk_storage` is set in defaults/main.yml.

Version-Release number of selected component (if applicable):
ovirt-engine-metrics-1.2.1-0.0.master.20190225200554.el7.noarch (patchset 56)

How reproducible:
100 %

Steps to Reproduce:
See BZ1679521 for reproduction steps. The way to verify this bug is just to check that /etc/ovirt-engine-metrics/config.yml.example mentions `ovirt_template_disk_storage` close to `openshift_ovirt_storage_domain_name` variable.

Comment 1 Shirly Radco 2019-03-07 07:42:44 UTC
I now populate the template_disk_storage based on ovirt_template_disk_storage.
template_disk_storage: {{ ovirt_template_disk_storage }}

Comment 2 Ivana Saranova 2019-04-04 09:20:38 UTC
The problem described in this bug is no more relevant after the changes made in the ovirt-engine-metrics package and therefore I suggest closing the bug as NOTABUG.


Note You need to log in before you can comment on or make changes to this bug.