Spec URL: http://petersen.fedorapeople.org//ghc-base-compat-batteries.spec SRPM URL: http://petersen.fedorapeople.org//ghc-base-compat-batteries-0.10.1-1.fc29.src.rpm Description: Provides functions available in later versions of 'base' to a wider range of compilers, without requiring you to use CPP pragmas in your code. This package provides the same API as the '<http://hackage.haskell.org/package/base-compat base-compat>' library, but depends on compatibility packages (such as 'semigroups') to offer a wider support window than 'base-compat', which has no dependencies. Most of the modules in this library have the same names as in 'base-compat' to make it easier to switch between the two. There also exist versions of each module with the suffix '.Repl.Batteries', which are distinct from anything in 'base-compat', to allow for easier use in GHCi. See '<https://github.com/haskell-compat/base-compat/blob/master/base-compat/README.markdown#dependencies here>' for a more comprehensive list of differences between 'base-compat' and 'base-compat-batteries'.
This requires ghc-8.4 to build. https://koji.fedoraproject.org/koji/taskinfo?taskID=33110605 (f30-ghc scratch build)
(In reply to Jens Petersen from comment #1) > https://koji.fedoraproject.org/koji/taskinfo?taskID=33110605 (f30-ghc > scratch build) Sorry buildroot was not build sufficiently yet.
Successful scratch with ghc-8.4 tree in Koji f30-ghc: https://koji.fedoraproject.org/koji/taskinfo?taskID=33113860 (Note this package won't build in current ghc-8.2 F30/Rawhide.)
Needed for hledger and criterion
- Please bump to 0.10.5 Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 131 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /ghc-base-compat-batteries/review-ghc-base-compat- batteries/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/ghc-8.4.4/package.conf.d, /usr/lib64/ghc-8.4.4 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2600960 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-base-compat-batteries-0.10.1-1.fc30.x86_64.rpm ghc-base-compat-batteries-devel-0.10.1-1.fc30.x86_64.rpm ghc-base-compat-batteries-0.10.1-1.fc30.src.rpm ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US pragmas -> pragmatism ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US hackage -> package, hack age, hack-age ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US haskell -> Haskell ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US semigroups -> semi groups, semi-groups, regroups ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US Repl -> Rep, Re pl, Re-pl ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US https -> HTTP ghc-base-compat-batteries.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub ghc-base-compat-batteries.x86_64: E: description-line-too-long C '<https://github.com/haskell-compat/base-compat/blob/master/base-compat/README.markdown#dependencies ghc-base-compat-batteries.x86_64: W: unstripped-binary-or-object /usr/lib64/libHSbase-compat-batteries-0.10.1-IPxu57w4ec7FknDPeWBhRo-ghc8.4.4.so ghc-base-compat-batteries.x86_64: W: no-documentation ghc-base-compat-batteries.src: W: spelling-error %description -l en_US pragmas -> pragmatism ghc-base-compat-batteries.src: W: spelling-error %description -l en_US hackage -> package, hack age, hack-age ghc-base-compat-batteries.src: W: spelling-error %description -l en_US haskell -> Haskell ghc-base-compat-batteries.src: W: spelling-error %description -l en_US semigroups -> semi groups, semi-groups, regroups ghc-base-compat-batteries.src: W: spelling-error %description -l en_US Repl -> Rep, Re pl, Re-pl ghc-base-compat-batteries.src: W: spelling-error %description -l en_US https -> HTTP ghc-base-compat-batteries.src: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub ghc-base-compat-batteries.src: E: description-line-too-long C '<https://github.com/haskell-compat/base-compat/blob/master/base-compat/README.markdown#dependencies 3 packages and 0 specfiles checked; 2 errors, 16 warnings.
Thank you for the reviews, this one is particular has effectively been blocking quite a number of f30-ghc builds. I prefer to update to 0.10.5 when we move to Stackage LTS 13 (ghc-8.6) later: LTS 12 is still on 0.10.1 - though I probably could get away with newer, not sure.
https://pagure.io/releng/fedora-scm-requests/issue/10099
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-base-compat-batteries
https://pagure.io/releng/fedora-scm-requests/issue/10272