Spec URL: http://petersen.fedorapeople.org//ghc-megaparsec.spec SRPM URL: http://petersen.fedorapeople.org//ghc-megaparsec-6.5.0-1.fc29.src.rpm Description: This is an industrial-strength monadic parser combinator library. Megaparsec is a feature-rich package that strikes a nice balance between speed, flexibility, and quality of parse errors.
This is to unsubpackage from hledger - also needed by idris. https://koji.fedoraproject.org/koji/taskinfo?taskID=33135193
- Latest version is 7.0.4 - The conditional %bcond_without tests is not used around %check: %check %cabal_test - Build error: DEBUG util.py:490: BUILDSTDERR: No matching package to install: 'hspec-discover' DEBUG util.py:490: BUILDSTDERR: Not all dependencies satisfied DEBUG util.py:490: BUILDSTDERR: Error: Some packages could not be found.
- From your Koji build it should be: BuildRequires: ghc-hspec-discover Package approved. Please fix the aforementioned issue before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (unspecified)", "BSD 2-clause "Simplified" License", "Unknown or generated". 36 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ghc-megaparsec/review- ghc-megaparsec/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2304000 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-megaparsec-6.5.0-1.fc31.x86_64.rpm ghc-megaparsec-devel-6.5.0-1.fc31.x86_64.rpm ghc-megaparsec-6.5.0-1.fc31.src.rpm ghc-megaparsec.x86_64: W: spelling-error Summary(en_US) Monadic -> Nomadic, Monodic ghc-megaparsec.x86_64: W: spelling-error Summary(en_US) combinators -> combinations, combination, contaminators ghc-megaparsec.x86_64: W: spelling-error %description -l en_US monadic -> nomadic, monodic ghc-megaparsec.x86_64: W: spelling-error %description -l en_US combinator -> combination, contaminator, coordinator ghc-megaparsec.x86_64: W: unstripped-binary-or-object /usr/lib64/libHSmegaparsec-6.5.0-HsQgNYmqF7j38kQHLO03HO-ghc8.2.2.so ghc-megaparsec.x86_64: W: no-documentation ghc-megaparsec.src: W: spelling-error Summary(en_US) Monadic -> Nomadic, Monodic ghc-megaparsec.src: W: spelling-error Summary(en_US) combinators -> combinations, combination, contaminators ghc-megaparsec.src: W: spelling-error %description -l en_US monadic -> nomadic, monodic ghc-megaparsec.src: W: spelling-error %description -l en_US combinator -> combination, contaminator, coordinator 3 packages and 0 specfiles checked; 0 errors, 10 warnings.
(In reply to Robert-André Mauchin from comment #3) > - From your Koji build it should be: > > BuildRequires: ghc-hspec-discover > > Package approved. Please fix the aforementioned issue before import. Apologies for not refreshing the uploaded spec and srpm. Thank you for the review! :-) https://pagure.io/releng/fedora-scm-requests/issue/10110 (I think I don't have any further reviews to file right now for F30, I hope.)
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-megaparsec
https://pagure.io/releng/fedora-scm-requests/issue/10263
(In reply to Robert-André Mauchin from comment #2) > - The conditional %bcond_without tests is not used around %check: > > %check > %cabal_test BTW these days %cabal_test already includes the conditional. :)