Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Text-Diff/perl-Text-Diff.spec SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Text-Diff-0.35-2.src.rpm Description: Text::Diff - Perform diffs on files and record sets.
Review for release 2: * RPM name is OK * Source Text-Diff-0.35.tar.gz is the same as upstream * Builds fine in mock * rpmlint of perl-Text-Diff looks OK * File list of perl-Text-Diff looks OK * Works fine Possible improvements: The fedora spec template for perl modules uses this in %build: CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS" These optimizations could be added.
(In reply to comment #1) > The fedora spec template for perl modules uses this in %build: > CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor > make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS" > These optimizations could be added. No, the perl template is broken. These flags are redundant. %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" make %{?_smp_mflags} is sufficient and correct in most cases
Steven, Could you import and build this one? It has already been approved several months ago. jpo
Sorry, I didn't catch that this one was approved. I'm importing it now...
Package Change Request ====================== Package Name: perl-Text-Diff New Branches: el6 Owners: steve InitialCC: perl-sig
Nevermind. It's in the optional repo.