Description of problem: `virt-xml myGuest --remove-device X` can remove only one device element at a call. However some devices like the first serial and console devices should be removed together otherwise removing one of them will not have any effect to the guest. How reproducible: Always Steps to Reproduce: 1. virt-xml testVm --remove-device --serial pty 2. virt-xml testVm --remove-device --console pty Actual results: `virsh dumpxml testVm` to confirm the serial and console pty is still there. Expected results: Removing either the serial or the console device should remove both from the guest's XML. virt-xml should probably special case the the serial device handling to remove the second device automatically if one the the two is marked for removal.
We have some special purpose logic for doing this in virtManager/domain.py, we need to get that into virtinst/ somehow it can be shared with virt-xml
Fixed upstream now: commit 44033b43bbda487bf8962f7d74de107f96aa2f47 Author: Cole Robinson <crobinso> Date: Tue Sep 8 17:55:09 2020 -0400 virt-xml: Handle removing <console> <serial> dup device