Fedora Account System
Red Hat Associate
Red Hat Customer
SPEC: http://v3.sk/~lkundrak/SPECS/console-setup.spec SRPM: http://v3.sk/~lkundrak/SRPMS/console-setup-1.189-1.fc29.src.rpm Description: This package contains the scripts, keyboard layouts and fonts used in Debian operating system to configure the text console equivalently to X11.
- There's some OFL and CDDL in there too: ICU License Common Development and Distribution License ------------------------------------------------------- console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ara console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/be console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/br console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ca console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ch console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/cz console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/de console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/dk console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ee console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/es console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/fi console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/fr console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/gb console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/gr console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/it console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/jp console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/kr console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/lt console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/lv console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/nl console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/no console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/pl console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/pt console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ro console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ru console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/se console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/sk console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/solaris console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/tr console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/tuv console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/tw console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/ua console-setup-1.189/Keyboard/ckb/symbols/sun_vndr/us SIL Open Font License (v1.1) ---------------------------- console-setup-1.189/Fonts/bdf/ter-u12b.bdf console-setup-1.189/Fonts/bdf/ter-u12n.bdf console-setup-1.189/Fonts/bdf/ter-u14b.bdf console-setup-1.189/Fonts/bdf/ter-u14n.bdf console-setup-1.189/Fonts/bdf/ter-u14v.bdf console-setup-1.189/Fonts/bdf/ter-u16b.bdf console-setup-1.189/Fonts/bdf/ter-u16n.bdf console-setup-1.189/Fonts/bdf/ter-u16v.bdf console-setup-1.189/Fonts/bdf/ter-u20b.bdf console-setup-1.189/Fonts/bdf/ter-u20n.bdf console-setup-1.189/Fonts/bdf/ter-u22b.bdf console-setup-1.189/Fonts/bdf/ter-u22n.bdf console-setup-1.189/Fonts/bdf/ter-u24b.bdf console-setup-1.189/Fonts/bdf/ter-u24n.bdf console-setup-1.189/Fonts/bdf/ter-u28b.bdf console-setup-1.189/Fonts/bdf/ter-u28n.bdf console-setup-1.189/Fonts/bdf/ter-u32b.bdf console-setup-1.189/Fonts/bdf/ter-u32n.bdf Add them to the License field. Add a comment explaining the license breakdown. - Fix the typo in your License field: ang → and, GPL-2.0 → GPLv2 License: Public Domain and MIT and GPLv2 - Patch the obsolete FSF address and send it upstream: console-setup.noarch: E: incorrect-fsf-address /usr/bin/ckbcomp bdf2psf.noarch: E: incorrect-fsf-address /usr/bin/bdf2psf - The CHANGES file is a symlink: include the actual file instead console-setup.noarch: W: dangling-relative-symlink /usr/share/doc/console-setup/CHANGES debian/changelog %doc debian/changelog Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ICU License Common Development and Distribution License", "FSF All Permissive License", "Unknown or generated", "GNU General Public License", "SIL Open Font License (v1.1)", "Creative Commons CC0 Public License", "*No copyright* GNU General Public License", "Expat License", "GPL (v2 or later) (with incorrect FSF address)", "NTP License", "NTP License (legal disclaimer)". 786 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /console-setup/review-console-setup/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package requires other packages for directories it uses. Note: No known owner of /etc/default [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/consolefonts(cava, console-setup, cmatrix) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bdf2psf [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: console-setup-1.189-1.fc31.noarch.rpm bdf2psf-1.189-1.fc31.noarch.rpm console-setup-1.189-1.fc31.src.rpm console-setup.noarch: W: invalid-license MIT ang GPL-2.0 console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ARMSCII-8.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.CP1251.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.CP1255.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.CP1256.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.GEORGIAN-ACADEMY.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.GEORGIAN-PS.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.IBM1133.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISIRI-3342.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-1.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-10.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-11.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-13.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-14.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-15.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-16.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-2.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-3.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-4.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-5.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-6.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-7.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-8.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.ISO-8859-9.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.KOI8-R.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.KOI8-U.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.TIS-620.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/compose.VISCII.inc console-setup.noarch: W: non-conffile-in-etc /etc/console-setup/remap.inc console-setup.noarch: E: incorrect-fsf-address /usr/bin/ckbcomp console-setup.noarch: W: dangling-relative-symlink /usr/share/doc/console-setup/CHANGES debian/changelog bdf2psf.noarch: W: invalid-license MIT ang GPL-2.0 bdf2psf.noarch: E: incorrect-fsf-address /usr/bin/bdf2psf console-setup.src: W: invalid-license MIT ang GPL-2.0 3 packages and 0 specfiles checked; 2 errors, 32 warnings.
Interesting package. Non format review yet. However it should be adapted to Fedora system more. For example /etc/default is not usually used on Fedora, instead similar purposes have /etc/sysconfig directory. I think %{_sysconfdir}/console-setup should be %config(noreplace) too, or it should be moved to %{_datadir}. Ideally if system distributed file was in %_datadir and user could modify its copy in %_sysconfdir. I think your spec does not conform to FontPolicy [1]. Fonts should be packaged separate from any other tools or code. As an example take kbd package and terminus-console-fonts package with only fonts. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/
I think such name cannot be used, because console-setup tools are already in Fedora [1]. If they are different, different package name has to be used or they have to be merged somehow. Maybe just complement package can be produced instead? 1. https://src.fedoraproject.org/rpms/console-setup
It seems it is the same package, but not providing the same binaries. Please work with the current maintainer to see all the features you need being implemented.
How could I miss this. Thank you and sorry for the noise. Created a PR for an existing package instead: https://src.fedoraproject.org/rpms/console-setup/pull-request/1