Bug 168607 - Review Request: perl-Convert-PEM
Review Request: perl-Convert-PEM
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Howarth
David Lawrence
http://search.cpan.org/dist/Convert-PEM/
:
Depends On: 168578 168583
Blocks: FE-ACCEPT perl-Crypt-DSA
  Show dependency treegraph
 
Reported: 2005-09-17 17:28 EDT by Steven Pritchard
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-02-02 22:12:21 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Steven Pritchard 2005-09-17 17:28:47 EDT
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Convert-PEM/perl-Convert-PEM.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Convert-PEM-0.07-2.src.rpm
Description:
This is Convert::PEM, a module implementing read/write access
to ASN.1-encoded PEM files (with optional encryption).
Comment 1 Paul Howarth 2005-11-25 12:53:12 EST
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- license text included, though not directly from upstream
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no duplicate files
- no permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs, docs don't affect runtime
- no desktop entry needed
- no scriptlets

Nitpick:

- files list should include:
  %{perl_vendorlib}/Convert/*
  rather than:
  %{perl_vendorlib}/*
  since the package depends on perl(Convert::ASN1), and the package containing
  that module owns the %{perl_vendorlib}/Convert directory

Suggestions:

- "Read/write encrypted ASN.1 PEM files" might be a better summary than
  "Convert::PEM Perl module"

- You might want to skip the license texts since upstream doesn't provide them

Approved
Comment 2 Ralf Corsepius 2005-11-25 13:06:14 EST
(In reply to comment #1)

> - files list should include:
>   %{perl_vendorlib}/Convert/*
>   rather than:
>   %{perl_vendorlib}/*
>   since the package depends on perl(Convert::ASN1), and the package containing
>   that module owns the %{perl_vendorlib}/Convert directory
Wrong - We have had this discussion before.

Both packages must own %{perl_vendorlib}/Convert because rpm does not assure any
particular order during multilib packag removals, such as
rpm -e '<all-packages owning %{perl_vendorlib}/Convert'
Comment 3 Paul Howarth 2005-11-25 14:15:45 EST
(In reply to comment #2)
> (In reply to comment #1)
> 
> > - files list should include:
> >   %{perl_vendorlib}/Convert/*
> >   rather than:
> >   %{perl_vendorlib}/*
> >   since the package depends on perl(Convert::ASN1), and the package containing
> >   that module owns the %{perl_vendorlib}/Convert directory
> Wrong - We have had this discussion before.
> 
> Both packages must own %{perl_vendorlib}/Convert because rpm does not assure any
> particular order during multilib packag removals, such as
> rpm -e '<all-packages owning %{perl_vendorlib}/Convert'

In that case I'd suggest that the sentence:

    If it does not create a directory that it uses, then it should
    require a package which does create that directory.

be removed from the package review guidelines:
http://fedoraproject.org/wiki/PackageReviewGuidelines

I think Spot should be the one to do that though.
Comment 4 Paul Howarth 2006-02-08 03:03:06 EST
Steve, can you do a build of this module for FC-4 please?
Comment 5 Steven Pritchard 2006-02-08 12:02:30 EST
I've been trying...

http://buildsys.fedoraproject.org/build-status/job.psp?uid=3816

I wonder if hammer2 is having issues.  I had another build fail on it yesterday
that worked fine on my x86_64 system under mock.
Comment 6 Steven Pritchard 2006-02-08 12:06:02 EST
Scratch that.  My other mystery failed build yesterday died on hammer3.
Comment 7 Paul Howarth 2006-03-02 07:45:53 EST
(In reply to comment #5)
> I've been trying...
> 
> http://buildsys.fedoraproject.org/build-status/job.psp?uid=3816
> 
> I wonder if hammer2 is having issues.  I had another build fail on it yesterday
> that worked fine on my x86_64 system under mock.

Could you give it another go, to see if it's one of those transient buildsystem
issues?
Comment 8 Steven Pritchard 2006-03-02 12:23:45 EST
Sorry, I forgot about this.  I requeued it, and it built this time.

Note You need to log in before you can comment on or make changes to this bug.