Bug 168611 - Review Request: linkchecker
Summary: Review Request: linkchecker
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://linkchecker.sourceforge.net/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-09-18 01:33 UTC by W. Michael Petullo
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2005-11-24 03:41:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description W. Michael Petullo 2005-09-18 01:33:33 UTC
Spec Name or Url: http://flyn.org/SRPMS/linkchecker.spec
SRPM Name or Url: http://flyn.org/SRPMS/linkchecker-3.2-1.src.rpm
Description:
Linkchecker is a simple script that checks HTML documents for broken links.

Comment 1 Aurelien Bompard 2005-09-25 16:47:11 UTC
- include the LICENSE file in %doc
- mark *.pyo files as %ghost (do not include in package).

Comment 2 W. Michael Petullo 2005-09-26 22:27:22 UTC
Spec Name or Url: http://flyn.org/SRPMS/linkchecker.spec
SRPM Name or Url: http://flyn.org/SRPMS/linkchecker-3.2-2.src.rpm

Made changes recommended by Aurelien.

Comment 3 Aurelien Bompard 2005-09-27 08:49:26 UTC
%{python_sitelib}/linkcheck/ and its subdirs are unowned, please add the
corresponding %dir statements in the %files list.
Everything else looks OK.

Comment 4 W. Michael Petullo 2005-10-24 01:35:32 UTC
Spec Name or Url: http://flyn.org/SRPMS/linkchecker.spec
SRPM Name or Url: http://flyn.org/SRPMS/linkchecker-3.2-3.src.rpm

Made changes recommended by Aurelien.

Comment 5 Aurelien Bompard 2005-10-24 07:23:20 UTC
Review for release 3:
* RPM name is OK
* Source linkchecker-3.2.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of linkchecker looks OK
* File list of linkchecker looks OK
* Works fine.
APPROVED

The latest version is 3.3. Please update after import.



Note You need to log in before you can comment on or make changes to this bug.