Description of problem: Some FTP URLs fails to be fetched, while curl and wget can fetch such URLs without a problem. Found that when trying to review bug #1658153. Version-Release number of selected component (if applicable): fedora-review-0.6.1-9.fc29.noarch How reproducible: reliable Steps to Reproduce: 1. fedora-review -b 1658153 2. 3. Actual results: INFO: Processing bugzilla bug: 1658153 INFO: Getting .spec and .srpm Urls from : 1658153 INFO: --> SRPM url: ftp://ftp.ourproject.org/pub/wdune/wdune-0.99rc1352-2.fc30.src.rpm INFO: --> Spec url: ftp://ftp.ourproject.org/pub/wdune/wdune.spec INFO: Using review directory: /home/reviewer/fedora/rawhide/1658153-wdune INFO: Downloading .spec and .srpm files ERROR: 'Error [Errno ftp error] 200 Type set to I downloading ftp://ftp.ourproject.org/pub/wdune/wdune.spec' (logs in /home/reviewer/.cache/fedora-review.log) -- fedora-review.log: 03-07 12:11 root INFO --> Spec url: ftp://ftp.ourproject.org/pub/wdune/wdune.spec 03-07 12:11 root DEBUG find_urls completed: 4.086 03-07 12:11 root INFO Using review directory: /home/reviewer/fedora/rawhide/1658153-wdune 03-07 12:11 root DEBUG Avoiding init of working mock root 03-07 12:11 root INFO Downloading .spec and .srpm files 03-07 12:12 root DEBUG ReviewError: 'Error [Errno ftp error] 200 Type set to I downloading ftp://ftp.ourproject.org/pub/wdune/wdune.spec' Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 237, in run self._do_run(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 226, in _do_run self._do_report(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 94, in _do_report if not self.bug.download_files(): File "/usr/lib/python2.7/site-packages/FedoraReview/abstract_bug.py", line 162, in download_files self.do_download_files() File "/usr/lib/python2.7/site-packages/FedoraReview/abstract_bug.py", line 124, in do_download_files self.do_download_spec() File "/usr/lib/python2.7/site-packages/FedoraReview/abstract_bug.py", line 93, in do_download_spec self.urlretrieve(self.spec_url, self.spec_file) File "/usr/lib/python2.7/site-packages/FedoraReview/helpers_mixin.py", line 94, in urlretrieve raise DownloadError(str(err), url) DownloadError: 'Error [Errno ftp error] 200 Type set to I downloading ftp://ftp.ourproject.org/pub/wdune/wdune.spec' 03-07 12:12 root ERROR ERROR: 'Error [Errno ftp error] 200 Type set to I downloading ftp://ftp.ourproject.org/pub/wdune/wdune.spec' (logs in /home/reviewer/.cache/fedora-review.log) Expected results: curl -O ftp://ftp.ourproject.org/pub/wdune/wdune.spec % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4302 100 4302 0 0 3430 0 0:00:01 0:00:01 --:--:-- 3430 Additional info: curl and wget can fetch that file successfully. Something is wrong in URL handling in fedora-review tool.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31.
This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.