Bug 1686794

Description of problem:
Can not provision VM on RHEL8 with Satellite. I think this consists of 2 issues:

D: do_call kickstart_guest.initiate('sat580.example.com', 'RHEL8_KVM_host:1:test2', 'qemu', 58, 'test2', 2048, 1, 5, 'virbr0', '/var/lib/libvirt/images/test2', ' '){'cache_only': None}
- looking for Cobbler at http://sat580.example.com/cobbler_api
--virt-type should be qemu, xenpv, xenfv, vmware, vmwarew, or auto but is kvm
D: Sending back response(1, 'Virtual kickstart failed. Koan error.', {'koan': '--virt-type should be qemu, xenpv, xenfv, vmware, vmwarew, or auto but is kvm'})

and if you overcome this (see "patch" below), then this:

- ['virt-install', '--connect', 'qemu:///system', '--name', 'test', '--ram', '2048', '--vcpus', '1', '--autostart', '--vnc', '--virt-type', 'kvm', '--machine', 'pc', '--extra-args=ks=http://sat580.example.com/cblr/svc/op/ks/system/RHEL8_KVM_host:1:test ksdevice=link lang= kssendmac text ', '--location', 'http://sat580.example.com/ty/7ruqSBLI/', '--os-variant', 'rhel8.0', '--disk', 'path=/var/lib/libvirt/images/test,size=5', '--network', 'bridge=virbr0,mac=00:16:3e:37:f1:64', '--wait', '0', '--noautoconsole']
ERROR    Error validating install location: Could not find an installable distribution at 'http://sat580.example.com/ty/7ruqSBLI/'

The location must be the root directory of an install tree.
See virt-install man page for various distro examples.
command failed (1)
D: Sending back response(1, 'Virtual kickstart failed. Koan error.', {'koan': 'command failed (1)'})


Version-Release number of selected component (if applicable):
[root@localhost ~]# rpm -qa | grep -e koan -e virt | sort
koan-2.0.7.1-2.module+el8+2757+b847be8a.noarch
libvirt-bash-completion-4.5.0-23.module+el8+2800+2d311f65.x86_64
libvirt-client-4.5.0-23.module+el8+2800+2d311f65.x86_64
libvirt-daemon-4.5.0-23.module+el8+2800+2d311f65.x86_64
libvirt-daemon-config-network-4.5.0-23.module+el8+2800+2d311f65.x86_64
libvirt-daemon-config-nwfilter-4.5.0-23.module+el8+2800+2d311f65.x86_64
libvirt-daemon-driver-interface-4.5.0-23.module+el8+2800+2d311f65.x86_64
[...]
libvirt-daemon-kvm-4.5.0-23.module+el8+2800+2d311f65.x86_64
libvirt-libs-4.5.0-23.module+el8+2800+2d311f65.x86_64
python3-koan-2.0.7.1-2.module+el8+2757+b847be8a.noarch
python3-libvirt-4.5.0-1.module+el8+2529+a9686a4d.x86_64
python3-rhn-virtualization-common-5.4.70-4.module+el8+2757+b847be8a.noarch
python3-rhn-virtualization-host-5.4.70-4.module+el8+2757+b847be8a.noarch
python3-spacewalk-koan-2.8.6-6.module+el8+2757+b847be8a.noarch
rhn-virtualization-host-5.4.70-4.module+el8+2757+b847be8a.noarch
spacewalk-koan-2.8.6-6.module+el8+2757+b847be8a.noarch
virt-install-2.0.0-4.el8.noarch
virt-manager-common-2.0.0-4.el8.noarch
virt-what-1.18-6.el8.x86_64


How reproducible:
always


Steps to Reproduce:
1. Sync RHEL and its KSs
2. Create kickstart profile with "KVM Virtualized Guest" virtualization type
3. Register KVM hypervisor and install rhn-virtualization-host package, add
   "Virtualization" entitlement to it
4. Attempt to provision a VM on the host
    Systems -> <kvm_host> -> Virtualization -> Provisioning
   select KS profile, fill in VM name and click "Schedule Kickstart and Finish"


Actual results:
See the first (and then the second) error above.


Expected results:
Should work, VM should be created


Additional info:
To workaround first issue, comment out this code:


--- /usr/lib/python3.6/site-packages/spacewalkkoan/spacewalkkoan.py.ORIG	2019-03-07 18:37:53.361329079 -0500
+++ /usr/lib/python3.6/site-packages/spacewalkkoan/spacewalkkoan.py	2019-03-07 18:49:10.366772611 -0500
@@ -229,12 +229,12 @@
         else:
             if os.path.exists(disk_path):
                 raise VirtDiskPathExistsError(disk_path)
-        # Switch to KVM if possible
-        if virt_type == "qemu":
-            if os.path.exists("/dev/kvm"):
-                virt_type = "kvm"
-            else:
-                print("Warning: KVM not available, using QEMU.")
+        ## Switch to KVM if possible
+        #if virt_type == "qemu":
+        #    if os.path.exists("/dev/kvm"):
+        #        virt_type = "kvm"
+        #    else:
+        #        print("Warning: KVM not available, using QEMU.")
         k = Koan()
         k.list_items          = 0
         k.server              = kickstart_host


Then code will go on and will fail on distro check (virt-manager-common package code differs on RHEL7 and RHEL8 - see '/usr/share/virt-manager/virtinst/installer.py' class 'Installer' method 'check_location') which can be fixed like this (on Satellite):


# cp /var/satellite/rhn/kickstart/ks-rhel-x86_64-baseos-8-8.0/treeinfo /var/satellite/rhn/kickstart/ks-rhel-x86_64-baseos-8-8.0/.treeinfo
# chown apache:apache /var/satellite/rhn/kickstart/ks-rhel-x86_64-baseos-8-8.0/.treeinfo