Bug 168682 - can't create ChangeLog entry for a field
Summary: can't create ChangeLog entry for a field
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: eclipse-changelog
Version: 4
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Foox
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-09-19 14:59 UTC by Tom Tromey
Modified: 2014-08-11 05:46 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-05-23 19:47:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch (863 bytes, patch)
2006-05-19 17:08 UTC, Kyu Lee
no flags Details | Diff

Description Tom Tromey 2005-09-19 14:59:39 UTC
If I put my cursor on a field and type M-C-a, I expect
a ChangeLog entry for the field to be created.  However,
instead I only get the file name and not the field name.

Comment 1 Phil Muldoon 2005-09-19 15:27:20 UTC
Can you drop a quick code snippet of the code the caret would be on when you
invoke the ChangeLog plug-in (just the code in context would be great), and the
expected ChangeLog entry from that (don't worry about author/date fields).

FWIW if the AST interrogation provides nothing, or something nonsensical, it
will strip it and the brackets and just include the filename. So it looks like
confusion on interrogating that particular language's AST model.


Comment 2 Tom Tromey 2005-09-19 15:30:24 UTC
Suppose you have a field definition like this:

  private static final long serialVersionUID = 0L;

I would expect the same ChangeLog result no matter where on the line
(at least, anywhere before the ";") the cursor appears, namely:

  * filename.java (serialVersionUID): <cursor here>

Right now I just see:

  * filename.java:


Comment 3 Kyu Lee 2006-05-19 17:08:39 UTC
Created attachment 129608 [details]
Patch

Comment 4 Kyu Lee 2006-05-19 17:10:08 UTC
I've fixed the bug, it should work now.

2006-05-19  Kyu Lee  <klee>

	* src/com/redhat/eclipse/changelog/core/parsers/JavaParser.java 
	(parseCurrentFunction): Fixed bug 168682.



Comment 5 Andrew Overholt 2006-05-23 18:57:38 UTC
I've applied this patch to CVS.  Thanks, Kyu.

Igor:  when you get a chance to spin a new release, can you close this bug?  Thanks.

Comment 6 Igor Foox 2006-05-23 19:47:06 UTC
I built 2.0.4 into dist-fc5-updates.

Comment 7 Andrew Overholt 2006-05-23 19:49:01 UTC
(In reply to comment #6)
> I built 2.0.4 into dist-fc5-updates.

Thanks, Igor.  Can you also build it into rawhide?

Comment 8 Igor Foox 2006-05-23 20:28:40 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I built 2.0.4 into dist-fc5-updates.
> 
> Thanks, Igor.  Can you also build it into rawhide?

Done.


Note You need to log in before you can comment on or make changes to this bug.