Bug 168694 - inner class members should be qualified
inner class members should be qualified
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: eclipse-changelog (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kyu Lee
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-19 12:27 EDT by Tom Tromey
Modified: 2014-08-11 01:46 EDT (History)
1 user (show)

See Also:
Fixed In Version: 2.1.0
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-10-05 11:14:16 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Bug fix (6.53 KB, patch)
2006-06-08 12:43 EDT, Kyu Lee
no flags Details | Diff

  None (edit)
Description Tom Tromey 2005-09-19 12:27:30 EDT
In a ChangeLog entry it is nice if an inner class entry
is qualified by its declaring class.  For instance given this code:

class Outer {
  class Inner {
    public void m() { ... }
  }
}

if the cursor is in the body of m(), the resulting ChangeLog entry should
look like this:

    * filename.java (Inner.m):

Currently only the member name is inserted.
Comment 1 Kyu Lee 2006-06-06 10:09:55 EDT
Should it ignore the upper most class name?

From your example,


    * filename.java (Inner.m):

 vs.

    * filename.java (Outer.Inner.m):

Comment 2 Tom Tromey 2006-06-06 11:08:14 EDT
Yes, it should ignore the outermost class name.
The GNU standards don't discuss this but common practice
is to avoid it, I suppose on the theory that most files
contain a single top-level class.

One other tweak is to use <clinit> when a change takes place in a
static initializer block.


Comment 3 Kyu Lee 2006-06-08 12:43:08 EDT
Created attachment 130764 [details]
Bug fix

This patch appends inner class names to methods/fields that are inside inner
classes(works recursively).
Comment 4 Andrew Overholt 2006-06-08 14:51:33 EDT
This patch looks good but the formatting seems a bit odd.  I assume Phil has
just been using the default JDT formatting rules so if you do an Esc Ctrl-F
and/or Ctrl-I, it should be fine.  I believe you have commit, so if the
formatting is what it should be (the patch may just look odd in firefox) and
you've written a ChangeLog entry, go ahead and commit :)

Thanks.
Comment 5 Kyu Lee 2006-06-08 16:18:41 EDT
I've fixed the format and now it's in CVS. :)
Comment 6 Ben Konrath 2006-10-04 16:09:28 EDT
Kyu, if this has been released, please close. Thanks.

Note You need to log in before you can comment on or make changes to this bug.