Hide Forgot
In a ChangeLog entry it is nice if an inner class entry is qualified by its declaring class. For instance given this code: class Outer { class Inner { public void m() { ... } } } if the cursor is in the body of m(), the resulting ChangeLog entry should look like this: * filename.java (Inner.m): Currently only the member name is inserted.
Should it ignore the upper most class name? From your example, * filename.java (Inner.m): vs. * filename.java (Outer.Inner.m):
Yes, it should ignore the outermost class name. The GNU standards don't discuss this but common practice is to avoid it, I suppose on the theory that most files contain a single top-level class. One other tweak is to use <clinit> when a change takes place in a static initializer block.
Created attachment 130764 [details] Bug fix This patch appends inner class names to methods/fields that are inside inner classes(works recursively).
This patch looks good but the formatting seems a bit odd. I assume Phil has just been using the default JDT formatting rules so if you do an Esc Ctrl-F and/or Ctrl-I, it should be fine. I believe you have commit, so if the formatting is what it should be (the patch may just look odd in firefox) and you've written a ChangeLog entry, go ahead and commit :) Thanks.
I've fixed the format and now it's in CVS. :)
Kyu, if this has been released, please close. Thanks.