Bug 1688083 - Review Request: golang-github-teris-io-shortid - Super short, fully unique, non-sequential and URL friendly Ids
Summary: Review Request: golang-github-teris-io-shortid - Super short, fully unique, n...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1670656
TreeView+ depends on / blocked
 
Reported: 2019-03-13 05:23 UTC by Nathan Scott
Modified: 2019-04-22 05:09 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-09 11:04:15 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Nathan Scott 2019-03-13 05:23:02 UTC
Spec URL: https://nathans.fedorapeople.org/shortid/golang-github-teris-io-shortid.spec
SRPM URL: https://nathans.fedorapeople.org/shortid/golang-github-teris-io-shortid-1.0-1.fc29.src.rpm
Description: Super short, fully unique, non-sequential and URL friendly Ids
Fedora Account System Username: nathans

Comment 1 Nathan Scott 2019-03-13 05:24:34 UTC
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33445645

Comment 2 Robert-André Mauchin 🐧 2019-03-13 21:41:46 UTC
 - use a better description:

%global common_description %{expand:
The package shortidenables the generation of short, fully unique, 
non-sequential and by default URL friendly Ids at a rate of hundreds of thousand 
per second. It guarantees uniqueness during the time period until 2050.}

[…]

%description
%{common_description}


%package devel
Summary:       %{summary}
BuildArch:     noarch

%description devel
%{common_description}


 - Don't mix tabs and spaces:

golang-github-teris-io-shortid.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 6)


 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issue.

Please add this package to the Go SIG, Anitya and Koschei once built.

Comment 3 Gwyn Ciesla 2019-03-14 19:50:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-teris-io-shortid

Comment 4 Elliott Sales de Andrade 2019-04-09 11:04:15 UTC
This appears to have been built: https://koji.fedoraproject.org/koji/buildinfo?buildID=1231739

Comment 5 Fedora Update System 2019-04-10 04:14:05 UTC
golang-github-teris-io-shortid-1.0-1.20190315git771a37c.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-087a2ae1cc

Comment 6 Fedora Update System 2019-04-10 04:14:26 UTC
golang-github-teris-io-shortid-1.0-1.20190315git771a37c.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8d98979b3b

Comment 7 Fedora Update System 2019-04-12 02:46:46 UTC
golang-github-teris-io-shortid-1.0-1.20190315git771a37c.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8d98979b3b

Comment 8 Fedora Update System 2019-04-12 03:55:37 UTC
golang-github-teris-io-shortid-1.0-1.20190315git771a37c.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-087a2ae1cc

Comment 9 Fedora Update System 2019-04-16 03:54:48 UTC
golang-github-teris-io-shortid-1.0-1.20190315git771a37c.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2019-04-22 05:09:22 UTC
golang-github-teris-io-shortid-1.0-1.20190315git771a37c.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.