Bug 1688362 - (6.4.z) HORNETQ-1559 Page.write() should throw exception if file is closed
Summary: (6.4.z) HORNETQ-1559 Page.write() should throw exception if file is closed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: RESTEasy
Version: 6.4.21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: CR1
: EAP 6.4.22
Assignee: Tomas Hofman
QA Contact: Peter Mackay
URL:
Whiteboard:
Depends On:
Blocks: eap6422-payload 1631773
TreeView+ depends on / blocked
 
Reported: 2019-03-13 15:39 UTC by Tomas Hofman
Modified: 2019-08-19 12:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-19 12:42:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker HORNETQ-1559 0 Major Closed Page.write() should throw exception if file is closed 2019-05-08 20:27:41 UTC

Description Tomas Hofman 2019-03-13 15:39:55 UTC
This is clone of https://issues.jboss.org/browse/HORNETQ-1559

=============================================================

In Page.write(final PagedMessage message) if the page file is closed it returns silently. The caller has no way to know that if the message is paged to file or not.
It should throw an exception so that the caller can handle it correctly.
This causes random failure in test org.hornetq.tests.integration.client.PagingTest#testExpireLargeMessageOnPaging().

Comment 1 Tomas Hofman 2019-03-13 15:45:25 UTC
This is to account for a code change in linked component upgrade.

Comment 2 Tomas Hofman 2019-03-13 15:47:53 UTC
@Brad will you ack?

Comment 3 Tomas Hofman 2019-03-13 15:48:55 UTC
@Brad ^

Comment 4 Tomas Hofman 2019-03-13 15:49:29 UTC
PR: https://github.com/hornetq/hornetq/commit/f388b3056b6e4cb0181f2797ac131893ddb956ab

No upstream required.

Comment 5 Peter Mackay 2019-05-08 20:29:05 UTC
Regression tests passed
Verified with EAP 6.4.22.CP.CR1


Note You need to log in before you can comment on or make changes to this bug.