Bug 1688392 - specfile problems
Summary: specfile problems
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Software Collections
Classification: Red Hat
Component: mariadb
Version: rh-mariadb103
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: alpha
: 3.3
Assignee: Michal Schorm
QA Contact: Karel Volný
URL:
Whiteboard:
Depends On:
Blocks: 1582609
TreeView+ depends on / blocked
 
Reported: 2019-03-13 16:42 UTC by Karel Volný
Modified: 2019-06-11 11:53 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-11 11:53:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2019:1435 0 None None None 2019-06-11 11:53:23 UTC

Description Karel Volný 2019-03-13 16:42:51 UTC
Description of problem:
there are a few problems in the specfile ...

Version-Release number of selected component (if applicable):
rh-mariadb103-mariadb-10.3.12-2.el7.src.rpm

How reproducible:
always

Steps to Reproduce:
1. rpmlint /root/rpmbuild/SPECS/mariadb.spec

Actual results:
/root/rpmbuild/SPECS/mariadb.spec:539: W: unversioned-explicit-provides bundled(rocksdb)
/root/rpmbuild/SPECS/mariadb.spec:962: E: hardcoded-library-path in %{_prefix}/lib/pkgconfig/libmariadb.pc
/root/rpmbuild/SPECS/mariadb.spec:1221: W: macro-in-comment %{scl_upper}
error: line 297: Unknown tag: Suggests:         mariadb-server(x86-64) = 3:10.3.12-2.el7a
0 packages and 1 specfiles checked; 1 errors, 2 warnings.


Expected results:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.


Additional info:
note that weak dependencies were added to rpm in 4.12 (ref bug 1086274), and the unsupported tag breaks spec parsing like

:: [ 12:25:48 ] :: [  BEGIN   ] :: Running 'python -c "import rpm; spec = rpm.spec('/root/rpmbuild/SPECS/mariadb.spec'); print (spec.build)"'
error: line 297: Unknown tag: Suggests:         mariadb-server(x86-64) = 3:10.3.12-2.el7a
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ValueError: can't parse specfile

Comment 4 Michal Schorm 2019-03-20 17:33:46 UTC
I fixed the pkgconfig part.

I got deeper into it and prepare a better patch for Fedora too:
https://src.fedoraproject.org/rpms/mariadb/c/943502fb6d2f17f263f94b72c5a7e48fb627b5b9?branch=master

--

> now the question is, why does it even install libmariadb.pc if it gets removed later?
Because we don't have control over what's installed when we build without client library.
We has to remove by hand the libraries, associated devel files ... and also the pkgconfig file.
However we need those files here at the build time for the rest of the DB to be built.


The right way would be to pass have such an option for CMake, which would set the files should be removed after build, when not distributing the client library.

Comment 5 Michal Schorm 2019-03-28 11:10:00 UTC
Adding an issue to this bug report:
 GSSapi plugin is built wrongly because of 2 typos in SPECfile ("gss" -> "ggs").

Let fix this as a part of this bugzilla.

(Fix for this issue was added to the commit)

Comment 14 errata-xmlrpc 2019-06-11 11:53:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1435


Note You need to log in before you can comment on or make changes to this bug.