Bug 1688786 - Review Request: perl-grpc-xs - Perl binding to gRPC library
Summary: Review Request: perl-grpc-xs - Perl binding to gRPC library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-14 12:53 UTC by Petr Pisar
Modified: 2019-03-15 14:07 UTC (History)
2 users (show)

Fixed In Version: perl-grpc-xs-0.20-1.fc31
Clone Of:
Environment:
Last Closed: 2019-03-15 14:07:31 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
CPAN 128840 0 None None None 2019-03-15 08:58:18 UTC

Description Petr Pisar 2019-03-14 12:53:38 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-grpc-xs/perl-grpc-xs.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-grpc-xs/perl-grpc-xs-0.20-1.fc31.src.rpm
Description:
This is a low-level binding to the gRPC library.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-14 15:58:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-grpc-xs-0.20-1.fc31.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libgrpc.so.7()(64bit)
      1 libperl.so.5.28()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(base)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(Grpc::Client::AbstractCall)
      1 perl(Grpc::Client::BidiStreamingCall)
      1 perl(Grpc::Client::ClientStreamingCall)
      1 perl(Grpc::Client::ServerStreamingCall)
      1 perl(Grpc::Client::UnaryCall)
      1 perl(Grpc::Constants)
      1 perl(Grpc::XS)
      1 perl(Grpc::XS::Call)
      1 perl(Grpc::XS::CallCredentials)
      1 perl(Grpc::XS::Channel)
      1 perl(Grpc::XS::Constants)
      1 perl(Grpc::XS::Timeval)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-grpc-xs-0.20-1.fc31.x86_64.rpm | sort | uniq -c
      1 perl(Grpc::Client::AbstractCall)
      1 perl(Grpc::Client::BaseStub)
      1 perl(Grpc::Client::BidiStreamingCall)
      1 perl(Grpc::Client::ClientStreamingCall)
      1 perl(Grpc::Client::ServerStreamingCall)
      1 perl(Grpc::Client::UnaryCall)
      1 perl(Grpc::Constants)
      1 perl(Grpc::XS) = 0.20
      1 perl-grpc-xs = 0.20-1.fc31
      1 perl(Grpc::XS::Call)
      1 perl(Grpc::XS::CallCredentials)
      1 perl(Grpc::XS::Channel)
      1 perl(Grpc::XS::ChannelCredentials)
      1 perl(Grpc::XS::Constants)
      1 perl(Grpc::XS::Server)
      1 perl(Grpc::XS::ServerCredentials)
      1 perl(Grpc::XS::Timeval)
      1 perl-grpc-xs(x86-64) = 0.20-1.fc31
Binary provides are Ok.

$ rpmlint ./perl-grpc-xs*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Resolution: Approved

Comment 2 Gwyn Ciesla 2019-03-14 17:02:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-grpc-xs

Comment 3 Petr Pisar 2019-03-15 07:09:33 UTC
Thank you for the review and the repository.

t/01-call_credentials.t test crashes on ppc64le, s390x, and armv7hl platforms with "double free or corruption (fasttop)".

Comment 4 Petr Pisar 2019-03-15 14:07:31 UTC
The crash was caused by an unannouncented change in grpc 1.7. I adapted perl-grpc-xs.


Note You need to log in before you can comment on or make changes to this bug.