Bug 168923 - Review Request: python-sqlobject - Python SQLObject ORM library -- needs sponsor
Review Request: python-sqlobject - Python SQLObject ORM library -- needs sponsor
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Shahms E. King
Fedora Package Reviews List
http://roughbook.de/blog/projekte/fed...
:
Depends On: 168922
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-09-21 07:25 EDT by Oliver Andrich
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-10-24 11:09:05 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Oliver Andrich 2005-09-21 07:25:42 EDT
Spec Name or Url: http://roughbook.de/review/python-sqlobject.spec
SRPM Name or Url: http://roughbook.de/review/python-sqlobject-0.7-0.5.b1.src.rpm
Description: Classes created using SQLObject wrap database rows, presenting a
friendly-looking Python object instead of a database/SQL interface.
Emphasizes convenience.  Works with MySQL, Postgres, SQLite, Firebird.

This package requires sqlite. Futher database connectors have to be installed
seperately.
Comment 1 Oliver Andrich 2005-10-02 08:05:45 EDT
Just wanted to drop an info, that I updated to the final version of SQL Object
0.7.0.

Spec Name or Url: http://roughbook.de/review/python-sqlobject.spec
SRPM Name or Url: http://roughbook.de/review/python-sqlobject-0.7.0-1.src.rpm
Comment 2 Oliver Andrich 2005-10-06 10:47:01 EDT
Once again an update to reflect a misconfigured requirement for FormEncode 0.2.2.

Spec Name or Url: http://roughbook.de/review/python-sqlobject.spec
SRPM Name or Url: http://roughbook.de/review/python-sqlobject-0.7.0-2.src.rpm
Comment 3 Shahms E. King 2005-10-12 17:04:17 EDT
(Changed this bug to depend on python-formencode)

Some changes:
 * rpmlint gives a "spelling-error-in-description" warning: seperately separately
   (it also finds some other, irrelevant, problems)
 * pass -O1 to the install command line
 * %ghost the resulting *.pyo files

It does build successfully under mock both with and without the above changes,
which is good.
Comment 4 Oliver Andrich 2005-10-13 14:24:14 EDT
Spec Name or Url: http://roughbook.de/review/python-sqlobject.spec
SRPM Name or Url: http://roughbook.de/review/python-sqlobject-0.7.0-3.src.rpm

I did the suggested changes and fixed the errors. Now the only things left are
twi rpmlint errors.

oa@fitheach SPECS $ rpmlint
/home/oa/rpmbuild/RPMS/noarch/python-sqlobject-0.7.0-3.noarch.rpm W:
python-sqlobject wrong-file-end-of-line-encoding
/usr/share/doc/python-sqlobject-0.7.0/docs/presentation-2004-11/sqlobject-and-database-programming.html
E: python-sqlobject non-executable-script
/usr/lib/python2.4/site-packages/sqlobject/manager/command.py 0644

Both of them are in the upstream source and cause no problems. Do I have to
correct these too?
Comment 5 Shahms E. King 2005-10-13 15:36:53 EDT
* rpmlint:
 - the end-of-line error is spurious as it is in an HTML documentation file
 - the non-executable script error is on a file that isn't used as a script, but
is imported by the sqlobject-admin script

* spec file name and package name match guidelines
* license is good
* spec file is clean and matches guidelines
* Source file and source URL md5sum matches
* spec file is legible english
* package compiles and runs on x86
* %clean is good
* macros are good

APPROVED
Comment 6 Christian Iseli 2007-01-02 18:27:15 EST
Changed summary for tracking purposes.

Note You need to log in before you can comment on or make changes to this bug.