Spec URL: http://blackbox.dinechin.org/fedora/make-it-quick.spec SRPM URL: http://blackbox.dinechin.org/fedora/make-it-quick.make-it-quick-0.2.2-1.fc29.src.rpm Description: A simple auto-configuring make-only build system Fedora Account System Username: ddd This is my first Fedora package. I am seeking a sponsor (I'm planning to ask rjones). Copr builds here: https://copr.fedorainfracloud.org/coprs/ddd/make-it-quick/builds/
rpmlint shows a number of errors like the following: make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_alloca.c This is normal. The project is primarily a development project, and needs the .c files for auto-configuration. I asked on the devel mailing list, and I was told that this is part of the policy, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages.
Link to the srpm in the review is a 404: ERROR: 'Error 404 downloading http://blackbox.dinechin.org/fedora/make-it-quick.make-it-quick-0.2.2-1.fc29.src.rpm'
Sorry, copy-paste error in the srpm link (I put a file there now). That was supposed to be http://blackbox.dinechin.org/fedora/make-it-quick-0.2.2-1.fc29.src.rpm
Comments on the spec file while fedora-review is running: Spec file looks sane and is quite simple. I guess COLORIZE stops the build system emitting ANSI color codes? If it's doing that, instead it should be checking isatty and suppressing them automatically. /usr/include looks like an odd place to be putting *.mk files. As they appear to be Makefile fragments intended for use by the tool it seems as if %{_datadir}/%{name} or %{_libdir}/%{name} might be better choices (the former if they are strictly arch-independent, the latter if not). Considering that you're already using %{_datadir}/%{name} too ... I'm not sure what the difference is between %{_datadir} and %{_datarootdir}. I have only ever used %{_datadir}. However they both expand to the same thing on my local machine. rpmlint is complaining a lot about make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_alloca.c However given the nature of the package I think we can pass on that warning.
(In reply to Richard W.M. Jones from comment #4) > Comments on the spec file while fedora-review is running: > > Spec file looks sane and is quite simple. > > I guess COLORIZE stops the build system emitting ANSI color codes? If it's > doing that, instead it should be checking isatty and suppressing them > automatically. Good idea, will check if [ -t 1 ] works portably (I'm concerned about mingw) > > /usr/include looks like an odd place to be putting *.mk files. As they > appear to be Makefile fragments intended for use by the tool it seems > as if %{_datadir}/%{name} or %{_libdir}/%{name} might be better choices (the > former if they are strictly arch-independent, the latter if not). > Considering that you're already using %{_datadir}/%{name} too ... Actually, this allows makefiles to do "include "make-it-quick/rules.mk" and everything works. As far as I know, make only looks under /usr/include. > > I'm not sure what the difference is between %{_datadir} and %{_datarootdir}. > I have only ever used %{_datadir}. However they both expand to the > same thing on my local machine. I don't know either, I copied that from another spec file (SPICE I believe) > > rpmlint is complaining a lot about > > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_alloca.c > > However given the nature of the package I think we can pass on that warning. Yes, I mentioned it in comment #1.
(In reply to Christophe de Dinechin from comment #5) > Actually, this allows makefiles to do "include "make-it-quick/rules.mk" and > everything works. As far as I know, make only looks under /usr/include. I meant to say: as opposed to /usr/share. The actual paths include the usual suspects, e.g. /usr/local/include, etc. See https://www.gnu.org/software/make/manual/html_node/Include.html.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. Licensing seems clear (GPLv3+). However source files in the project do not contain properly formatted GPL notices. While this is not an absolute requirement, it would greatly help and I think you should make that change upstream. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/make-it-quick, /usr/share/make-it- quick/config, /usr/include/make-it-quick Package needs to own these directories. You could either add: %dir %{_datarootdir}/%{name} (for each %dir) or you could simply specify the directory and rpmbuild will recursively find every file in the directory, eg: %{_datarootdir}/%{name} In the second case you risk adding files unintentionally to the final package. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/make-it-quick, /usr/share/make-it-quick/config, /usr/include/make-it-quick See previous point. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package I think the pkg-config file (*.pc) should probably go into a -devel subpackage. It's at least arguable since the whole package is for development, but it seems like it may be better. I'm assuming the *.c files are used for normal operation and so should stay in the main package, even though rpmlint warns. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. Use of /usr/include is dubious. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. Does it require 'make' at runtime? It doesn't depend on it at runtime. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. Did not test. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines See concerns above. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). Maybe missing 'make' dependency at runtime. [ ]: Package functions as described. Did not test. Should it have a %check section which tests the package performs minimally? [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: The placement of pkgconfig(.pc) files are correct. Note: make-it-quick : /usr/share/pkgconfig/make-it-quick.pc [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Rpmlint ------- Checking: make-it-quick-0.2.2-1.fc29.noarch.rpm make-it-quick-0.2.2-1.fc29.src.rpm make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_alloca.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_clearenv.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_drand48.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_egl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gdk_event_get_scancode.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_getpeereid.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_glob.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstaudio.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstvideo.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_int64.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_longlong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_mingw_aligned_malloc.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authority_get_sync.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authorization_result_get_dismissed.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_posix_memalign.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_pulse.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sasl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sbrk.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_strtok_r.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_stat.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uchar.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uint.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ulong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ushort.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/make-it-quick.pc 2 packages and 0 specfiles checked; 0 errors, 27 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory make-it-quick.noarch: W: invalid-url URL: https://gitlab.com/c3d/make-it-quick <urlopen error [Errno -2] Name or service not known> make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_alloca.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_clearenv.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_drand48.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_egl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gdk_event_get_scancode.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_getpeereid.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_glob.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstaudio.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_gstvideo.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_int64.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_longlong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_mingw_aligned_malloc.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authority_get_sync.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_polkit_authorization_result_get_dismissed.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_posix_memalign.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_pulse.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sasl.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sbrk.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_strtok_r.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_sigaction.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_struct_stat.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uchar.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_uint.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ulong.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/make-it-quick/config/check_ushort.c make-it-quick.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/make-it-quick.pc 1 packages and 0 specfiles checked; 0 errors, 28 warnings. Requires -------- make-it-quick (rpmlib, GLIBC filtered): /usr/bin/pkg-config sed Provides -------- make-it-quick: make-it-quick pkgconfig(make-it-quick) Source checksums ---------------- https://github.com/c3d/make-it-quick/archive/v0.2.2/make-it-quick-0.2.2.tar.gz : CHECKSUM(SHA256) this package : 7fad45b253e1a65da93ddedc023f64017373a0fe9102a3a96516531d788f648f CHECKSUM(SHA256) upstream package : 7fad45b253e1a65da93ddedc023f64017373a0fe9102a3a96516531d788f648f Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1689277 Buildroot used: fedora-29-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Christophe de Dinechin from comment #6) > (In reply to Christophe de Dinechin from comment #5) > > Actually, this allows makefiles to do "include "make-it-quick/rules.mk" and > > everything works. As far as I know, make only looks under /usr/include. > > I meant to say: as opposed to /usr/share. The actual paths include the usual > suspects, e.g. /usr/local/include, etc. See > https://www.gnu.org/software/make/manual/html_node/Include.html. Hmm ok, interesting point. I'll let this point pass but don't be surprised if someone else queries it at some point in the future.
(In reply to Richard W.M. Jones from comment #7) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc gcc-c++ make For make, it was to specify the minimum version number (although, granted, make 3.81 is quite obsolete by now). for gcc and gcc-c++, I also added version numbers because the tests are written in C11, and this is failing e.g. on EPEL. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > > ===== MUST items ===== > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [ ]: License field in the package spec file matches the actual license. > Note: There is no build directory. Running licensecheck on vanilla > upstream sources. No licenses found. Please check the source files for > licenses manually. > > Licensing seems clear (GPLv3+). However source files in the project do > not contain properly formatted GPL notices. While this is not an absolute > requirement, it would greatly help and I think you should make that change > upstream. Good idea. Done. Will also do it for my other projects. > > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/make-it-quick, /usr/share/make-it- > quick/config, /usr/include/make-it-quick > > Package needs to own these directories. You could either add: > > %dir %{_datarootdir}/%{name} > (for each %dir) > > or you could simply specify the directory and rpmbuild will recursively > find every file in the directory, eg: > > %{_datarootdir}/%{name} Fixed. I had seen %dir directives in the SPICE spec file, but I had not taken the time to search what it was (BTW, did not find a good macro index for RPM) > > In the second case you risk adding files unintentionally to the final > package. > > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/make-it-quick, > /usr/share/make-it-quick/config, /usr/include/make-it-quick > > See previous point. Done. Review now shows: [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. > > [x]: Package contains no bundled libraries without FPC exception. > [-]: Changelog in prescribed format. > [x]: Sources contain only permissible code or content. > [-]: Package contains desktop file if it is a GUI application. > [!]: Development files must be in a -devel package > > I think the pkg-config file (*.pc) should probably go into a -devel > subpackage. It's at least arguable since the whole package is for > development, but it seems like it may be better. OK. Done. > > I'm assuming the *.c files are used for normal operation and so > should stay in the main package, even though rpmlint warns. Yes, see comment #1 > > [x]: Package uses nothing in %doc for runtime. > [x]: Package consistently uses macros (instead of hard-coded directory > names). > [x]: Package is named according to the Package Naming Guidelines. > [x]: Package does not generate any conflict. > [?]: Package obeys FHS, except libexecdir and /usr/target. > > Use of /usr/include is dubious. The .mk files are include files. make include files, granted, but still include files. The dubious decision of searching include files in /usr/include was not made by me but by GNU. I tried to mitigate it by having a specific subdirectory with a rather long name that is unlikely to ever be used by a C/C++ program. (the package was initially called `build` and was renamed precisely because I felt #include <build/...> might cause conflict) > > [-]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > [?]: Requires correct, justified where necessary. > > Does it require 'make' at runtime? It doesn't depend on it at runtime. Well, it's practically unusable without make, but it does not seem to be a dependency in the classical sense. Makes sense to add it though. Added to the new iteration. > > [x]: Spec file is legible and written in American English. > [-]: Package contains systemd file(s) if in need. > [-]: Package is not known to require an ExcludeArch tag. > > Did not test. It's a noarch package. Does that rule apply? > > [-]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 30720 bytes in 3 files. > [ ]: Package complies to the Packaging Guidelines > > See concerns above. > > [x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > [x]: Package installs properly. > [x]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > [x]: Package does not own files or directories owned by other packages. > [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT > [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > [x]: Macros in Summary, %description expandable at SRPM build time. > [x]: Dist tag is present. > [x]: Package does not contain duplicates in %files. > [x]: Permissions on files are set properly. > [x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. > [x]: Package is named using only allowed ASCII characters. > [x]: Package does not use a name that already exists. > [x]: Package is not relocatable. > [x]: Sources used to build the package match the upstream source, as > provided in the spec URL. > [x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [x]: File names are valid UTF-8. > [x]: Packages must not store files under /srv, /opt or /usr/local > > ===== SHOULD items ===== > > Generic: > [-]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [ ]: Final provides and requires are sane (see attachments). > > Maybe missing 'make' dependency at runtime. Added. > > [ ]: Package functions as described. > > Did not test. Should it have a %check section which tests the package > performs minimally? > > [x]: Latest version is packaged. > [x]: Package does not include license text files separate from upstream. > [?]: The placement of pkgconfig(.pc) files are correct. > Note: make-it-quick : /usr/share/pkgconfig/make-it-quick.pc I think the [?] was because of -devel package? If so, fixed. > [-]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. > [-]: Package should compile and build into binary rpms on all supported > architectures. > [-]: %check is present and all tests pass. > [-]: Packages should try to preserve timestamps of original installed > files. > [x]: Reviewer should test that the package builds in mock. > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. > > Rpmlint > ------- > Checking: make-it-quick-0.2.2-1.fc29.noarch.rpm > make-it-quick-0.2.2-1.fc29.src.rpm > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_alloca.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_clearenv.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_drand48.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_egl.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_gdk_event_get_scancode.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_getpeereid.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_glob.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_gstaudio.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_gstvideo.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_int64.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_longlong.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_mingw_aligned_malloc.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_polkit_authority_get_sync.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/ > check_polkit_authorization_result_get_dismissed.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_posix_memalign.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_pulse.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_sasl.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_sbrk.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_sigaction.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_strtok_r.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_struct_sigaction.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_struct_stat.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_uchar.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_uint.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_ulong.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_ushort.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/pkgconfig/make-it-quick.pc > 2 packages and 0 specfiles checked; 0 errors, 27 warnings. > > > > > Rpmlint (installed packages) > ---------------------------- > sh: /usr/bin/python: No such file or directory > make-it-quick.noarch: W: invalid-url URL: > https://gitlab.com/c3d/make-it-quick <urlopen error [Errno -2] Name or > service not known> Good catch, was supposed to be github. > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_alloca.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_clearenv.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_drand48.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_egl.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_gdk_event_get_scancode.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_getpeereid.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_glob.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_gstaudio.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_gstvideo.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_int64.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_longlong.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_mingw_aligned_malloc.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_polkit_authority_get_sync.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/ > check_polkit_authorization_result_get_dismissed.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_posix_memalign.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_pulse.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_sasl.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_sbrk.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_sigaction.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_strtok_r.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_struct_sigaction.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_struct_stat.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_uchar.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_uint.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_ulong.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/make-it-quick/config/check_ushort.c > make-it-quick.noarch: W: devel-file-in-non-devel-package > /usr/share/pkgconfig/make-it-quick.pc > 1 packages and 0 specfiles checked; 0 errors, 28 warnings. > > > > Requires > -------- > make-it-quick (rpmlib, GLIBC filtered): > /usr/bin/pkg-config > sed > > > > Provides > -------- > make-it-quick: > make-it-quick > pkgconfig(make-it-quick) > > > > Source checksums > ---------------- > https://github.com/c3d/make-it-quick/archive/v0.2.2/make-it-quick-0.2.2.tar. > gz : > CHECKSUM(SHA256) this package : > 7fad45b253e1a65da93ddedc023f64017373a0fe9102a3a96516531d788f648f > CHECKSUM(SHA256) upstream package : > 7fad45b253e1a65da93ddedc023f64017373a0fe9102a3a96516531d788f648f > > > Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 > Command line :/usr/bin/fedora-review -b 1689277 > Buildroot used: fedora-29-x86_64 > Active plugins: Generic, Shell-api > Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, > Haskell, R, PHP > Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
> > [-]: Package is not known to require an ExcludeArch tag. > > > > Did not test. > > It's a noarch package. Does that rule apply? Yes you're right this rule doesn't apply to noarch packages.
I downloaded the updated spec file and new source release and built it and it looks fine now. There is one stylistic point: normally the %package devel description (not %files devel) would be placed earlier in the spec file, for example above %prep. All the %files sections would be kept together. However it does not seem to affect RPM which has no problem building the current spec file. What you need to do next is add a comment giving the latest Spec URL, SRPM URL and Description. Then I can approve the review and it should be added to Fedora. You will also need to get sponsored into the Fedora packaging group if you are not sponsored already.
Spec URL: http://blackbox.dinechin.org/fedora/make-it-quick.spec SRPM URL: http://blackbox.dinechin.org/fedora/make-it-quick-0.2.4-1.fc29.src.rpm Description: A simple auto-configuring make-only build system Fedora Account System Username: ddd This is my first Fedora package. I am seeking a sponsor Copr builds: https://copr.fedorainfracloud.org/coprs/ddd/make-it-quick/builds/
The changes have been made and the review APPROVED by rjones
I will sponsor Christophe into the package maintainers group. Christophe, when applying to create this package, please make sure to add me as a co-maintainer.
(In reply to Richard W.M. Jones from comment #14) > Christophe, when applying to create this package, > please make sure to add me as a co-maintainer. I've added you as "admin" in https://src.fedoraproject.org/rpms/make-it-quick. Is that what you meant as "adding you as co-maintainer", or something else? I had some issues getting the project assigned to me, but it was fixed. I did koji builds for f29, f30 and rawhide, so unless there is something I missed, I'm ready to close this ticket.
I'm not sure either. They changed the UI from something which was quite easy to understand to Pagure which is obscure and strange. Anyway you can't close this bug yet because you haven't finished the builds for each non-Rawhide build (ie. F29, F30) you must submit an update. Do: fedpkg update in each branch. ALSO you must link this bug to each update (see the form that you get when you do 'fedpkg update'). When the bug is linked to update(s) it will be closed automatically at the right time.
make-it-quick-0.2.4-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f6bc44c5e5
make-it-quick-0.2.4-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-34d0d1010f
make-it-quick-0.2.5-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0a9d5e5e67
make-it-quick-0.2.5-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-393533478e
make-it-quick-0.2.5-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0a9d5e5e67
make-it-quick-0.2.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-393533478e
make-it-quick-0.2.5-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
make-it-quick-0.2.5-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.