Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1689867

Summary:	Undercloud: ironic_pxe_http containers healthcheck missing
Product:	Red Hat OpenStack	Reporter:	Sasha Smolyak <ssmolyak>
Component:	openstack-tripleo-heat-templates	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED ERRATA	QA Contact:	mlammon
Severity:	medium	Docs Contact:
Priority:	medium
Version:	15.0 (Stein)	CC:	bfournie, derekh, dtantsur, mburns
Target Milestone:	z2	Keywords:	Triaged, ZStream
Target Release:	15.0 (Stein)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-10.6.2-0.20191202200455.41d9f8a.el8ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-05 11:59:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sasha Smolyak 2019-03-18 10:27:08 UTC

Description of problem:
When running healthcheck for containers on undercloud, the ironic_pxe_http container is present, but the healthcheck for it is missing:
ironic_inspector_dnsmasq status=0/SUCCESS
ironic_inspector status=0/SUCCESS
ironic_pxe_tftp status=0/SUCCESS
Unit tripleo_ironic_pxe_http_healthcheck.service could not be found.


Version-Release number of selected component (if applicable):
puppet-ironic-14.3.0-0.20190313150338.5c82a02.el8ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy undercloud
2. Observe containers list: sudo podman ps
3. Run healthcheck: 
systemctl status tripleo_ironic_pxe_http_healthcheck.service

Actual results:
Unit tripleo_ironic_pxe_http_healthcheck.service could not be found.

Expected results:
ironic_pxe_http status=0/SUCCESS

Additional info:

Comment 1 Bob Fournier 2019-04-11 15:55:38 UTC

Can you please retest with first OSP-15 compose?

Comment 2 Derek Higgins 2019-04-11 22:32:16 UTC

I don't currently have a undercloud to test on, but the healthcheck seems to be missing from the heat template, are you able to try out this patch?
https://review.openstack.org/#/c/651937/1

Comment 3 Sasha Smolyak 2019-04-17 13:41:52 UTC

Deployment failed when adding this patch

Comment 4 Artem Hrechanychenko 2019-04-18 09:24:15 UTC

Also please add h(In reply to Derek Higgins from comment #2)
> I don't currently have a undercloud to test on, but the healthcheck seems to
> be missing from the heat template, are you able to try out this patch?
> https://review.openstack.org/#/c/651937/1

Also add healthcheck for ironic_neutron_agent too - is also doesn't exist on Undercloud node after installation

Comment 5 Bob Fournier 2019-05-23 21:52:51 UTC

It looks like the ironic_pxe_http container does have the healthcheck (along with ironic_pxe_tftp):

[root@undercloud-0 ~]# podman exec -it ironic_pxe_http ls -al /openstack
total 0
drwxr-xr-x. 2 root root 25 May 20 12:36 .
drwxr-xr-x. 1 root root 81 May 21 15:18 ..
lrwxrwxrwx. 1 root root 58 May 20 12:36 healthcheck -> /usr/share/openstack-tripleo-common/healthcheck/ironic-pxe

I think Derek's patch is needed to start the service - https://review.opendev.org/#/c/651937.

For the ironic_neutron_agent container, there is no healthcheck in the container:
[root@undercloud-0 ~]# podman exec -it ironic_neutron_agent ls -al /openstack
ls: cannot access '/openstack': No such file or directory

A healthcheck would have to be written and added to the container in tripleo-common/container-images/tripleo_kolla_template_overrides.j2.

It probably makes sense to split these into separate bugs as the changes will be quite different.

Comment 6 Bob Fournier 2019-06-06 00:10:06 UTC

This bug is only to enable the ironic_pxe_http healthcheck.  Will create a separate one for ironic_neutron_agent as that requires writing a whole new health check.

Comment 9 Bob Fournier 2020-02-20 16:09:40 UTC

In /var/log/messages, now see that the healthcheck is running:

Feb 19 16:24:11 undercloud-0 systemd[1]: Starting ironic_pxe_http healthcheck...
Feb 19 16:24:11 undercloud-0 healthcheck_ironic_pxe_http[66384]: /usr/sbin/httpd -DFOREGROUND
Feb 19 16:24:11 undercloud-0 podman[66384]: 2020-02-19 16:24:11.576904158 +0000 UTC m=+0.317924578 container exec f3ca77e64c205b303820045755e4bd457ce477dbefcb4263d1aa693f2c0341e9 (image=192.168.24.1:8787/rh-osbs/rhosp15-openstack-ironic-pxe:20200207.2, name=ironic_pxe_http)
Feb 19 16:24:11 undercloud-0 healthcheck_neutron_ovs_agent[66383]: Sorry, user neutron is not allowed to execute '/usr/sbin/ss -ntuap' as neutron on undercloud-0.redhat.local.
Feb 19 16:24:11 undercloud-0 healthcheck_ironic_pxe_http[66384]: 200 127.0.0.1:8088 0.001199 seconds
Feb 19 16:24:11 undercloud-0 systemd[1]: Started ironic_pxe_http healthcheck.

Comment 11 errata-xmlrpc 2020-03-05 11:59:04 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0643