Bug 1690245
| Summary: | [xfstests xfs/010]: wrong finobt record decoding when sparse inodes enabled | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Zorro Lang <zlang> |
| Component: | xfsprogs | Assignee: | Eric Sandeen <esandeen> |
| Status: | CLOSED ERRATA | QA Contact: | Zorro Lang <zlang> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 8.0 | CC: | xzhou |
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
| Target Release: | 8.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-11-05 22:30:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Built in xfsprogs-5.0.0-1.el8 Reproduced on kernel 80.el8:
# ./check xfs/010
FSTYP -- xfs (non-debug)
PLATFORM -- Linux/x86_64 hp-dl580g7-04 4.18.0-80.el8.x86_64+debug
MKFS_OPTIONS -- -f -bsize=4096 /dev/loop0
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop0 /mnt/scratch
xfs/010 - output mismatch (see /root/git/xfstests-dev/results//xfs/010.out.bad)
--- tests/xfs/010.out 2018-08-28 13:01:12.811691224 +0800
+++ /root/git/xfstests-dev/results//xfs/010.out.bad 2019-06-12 17:27:07.356431469 +0800
@@ -13,7 +13,9 @@
- zero log...
- scan filesystem freespace and inode maps...
finobt ir_freecount/free mismatch, AGNO/INO, freecount 70 nfree 2
+invalid inode count, AGNO/INO, count 0 ninodes 64
finobt record with no free inodes, AGNO/INO
+invalid inode count, AGNO/INO, count 0 ninodes 64
- found root inode chunk
...
(Run 'diff -u /root/git/xfstests-dev/tests/xfs/010.out /root/git/xfstests-dev/results//xfs/010.out.bad' to see the entire diff)
Ran: xfs/010
Failures: xfs/010
Failed 1 of 1 tests
Test passed on kernel 103.el8:
# ./check xfs/010
common/config: SCRATCH_DEV (/dev/loop0) is not a block device or a network filesystem
[root@hp-dl380pg8-01 xfstests-dev]# losetup -f
/dev/loop0
[root@hp-dl380pg8-01 xfstests-dev]# losetup /dev/loop0 /home/scratchimg
[root@hp-dl380pg8-01 xfstests-dev]# ./check xfs/010
FSTYP -- xfs (non-debug)
PLATFORM -- Linux/x86_64 hp-dl380pg8-01 4.18.0-103.el8.x86_64+debug
MKFS_OPTIONS -- -f -bsize=4096 /dev/loop0
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop0 /mnt/scratch
xfs/010 22s ... 17s
Ran: xfs/010
Passed all 1 tests
(In reply to Zorro Lang from comment #3) > Reproduced on kernel 80.el8: Reproduced on xfsprogs-4.19.0-2.el8 > # ./check xfs/010 > FSTYP -- xfs (non-debug) > PLATFORM -- Linux/x86_64 hp-dl580g7-04 4.18.0-80.el8.x86_64+debug > MKFS_OPTIONS -- -f -bsize=4096 /dev/loop0 > MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop0 > /mnt/scratch > > xfs/010 - output mismatch (see > /root/git/xfstests-dev/results//xfs/010.out.bad) > --- tests/xfs/010.out 2018-08-28 13:01:12.811691224 +0800 > +++ /root/git/xfstests-dev/results//xfs/010.out.bad 2019-06-12 > 17:27:07.356431469 +0800 > @@ -13,7 +13,9 @@ > - zero log... > - scan filesystem freespace and inode maps... > finobt ir_freecount/free mismatch, AGNO/INO, freecount 70 nfree 2 > +invalid inode count, AGNO/INO, count 0 ninodes 64 > finobt record with no free inodes, AGNO/INO > +invalid inode count, AGNO/INO, count 0 ninodes 64 > - found root inode chunk > ... > (Run 'diff -u /root/git/xfstests-dev/tests/xfs/010.out > /root/git/xfstests-dev/results//xfs/010.out.bad' to see the entire diff) > Ran: xfs/010 > Failures: xfs/010 > Failed 1 of 1 tests > > Test passed on kernel 103.el8: Test passed on xfsprogs-5.0.0-1.el8.x86_64 > # ./check xfs/010 > common/config: SCRATCH_DEV (/dev/loop0) is not a block device or a network > filesystem > [root@hp-dl380pg8-01 xfstests-dev]# losetup -f > /dev/loop0 > [root@hp-dl380pg8-01 xfstests-dev]# losetup /dev/loop0 /home/scratchimg > [root@hp-dl380pg8-01 xfstests-dev]# ./check xfs/010 > FSTYP -- xfs (non-debug) > PLATFORM -- Linux/x86_64 hp-dl380pg8-01 4.18.0-103.el8.x86_64+debug > MKFS_OPTIONS -- -f -bsize=4096 /dev/loop0 > MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop0 > /mnt/scratch > > xfs/010 22s ... 17s > Ran: xfs/010 > Passed all 1 tests Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:3628 |
Description of problem: xfs/010 fails on latest xfsprogs-4.19.0-2.el8: # ./check xfs/010 FSTYP -- xfs (non-debug) PLATFORM -- Linux/x86_64 hp-dl380pg8-01 4.18.0-80.el8.x86_64+debug MKFS_OPTIONS -- -f -bsize=4096 /dev/mapper/rhel_hp--dl380pg8--01-xfscratch MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/mapper/rhel_hp--dl380pg8--01-xfscratch /mnt/scratch xfs/010 22s ... - output mismatch (see /home/xfstests-dev/results//xfs/010.out.bad) --- tests/xfs/010.out 2018-10-16 23:31:53.959269493 -0400 +++ /home/xfstests-dev/results//xfs/010.out.bad 2019-03-19 01:53:32.450494557 -0400 @@ -13,7 +13,9 @@ - zero log... - scan filesystem freespace and inode maps... finobt ir_freecount/free mismatch, AGNO/INO, freecount 70 nfree 2 +invalid inode count, AGNO/INO, count 0 ninodes 64 finobt record with no free inodes, AGNO/INO +invalid inode count, AGNO/INO, count 0 ninodes 64 - found root inode chunk ... (Run 'diff -u /home/xfstests-dev/tests/xfs/010.out /home/xfstests-dev/results//xfs/010.out.bad' to see the entire diff) Ran: xfs/010 Failures: xfs/010 Failed 1 of 1 tests Version-Release number of selected component (if applicable): xfsprogs-4.19.0-2.el8 How reproducible: 100% Steps to Reproduce: Run latest xfstests xfs/010 on sparse inode enabled XFS Actual results: Expected results: Additional info: 1) I think it's refer to: commit 38c599e7782ced7d2d1b41c3182daeaddad2cee4 Author: Darrick J. Wong <darrick.wong> Date: Mon Jan 28 13:03:15 2019 -0600 xfs_db: fix finobt record decoding when sparse inodes enabled 2) Feel free to close DUP this bug after we rebase xfsprogs to latest upstream version.