Bug 1690268 - [UI] Uncaught exception occurred on Edit host
Summary: [UI] Uncaught exception occurred on Edit host
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.3.1
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ovirt-4.3.3
: ---
Assignee: Kaustav Majumder
QA Contact: Pavel Novotny
URL:
Whiteboard:
: 1691286 1691737 1692130 1698331 1699484 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-19 08:16 UTC by Michael Burman
Modified: 2020-06-19 05:16 UTC (History)
16 users (show)

Fixed In Version: ovirt-engine-4.3.3.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-16 13:58:09 UTC
oVirt Team: Gluster
Embargoed:
pm-rhel: ovirt-4.3+
pm-rhel: blocker+
godas: devel_ack+
lleistne: testing_ack+


Attachments (Terms of Use)
ui log (1.50 KB, application/gzip)
2019-03-19 15:03 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 98691 0 'None' MERGED webadmin: Uncaught exception occurred on Edit host 2020-11-24 07:11:54 UTC
oVirt gerrit 98704 0 'None' MERGED webadmin: Uncaught exception occurred on Edit host 2020-11-24 07:11:54 UTC

Description Michael Burman 2019-03-19 08:16:52 UTC
Description of problem:
[UI] Uncaught exception occurred on Edit host

2019-03-19 10:13:08,774+02 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-1) [] Permutation name: 54B253B900B509AE26132CCEEEC4E3A4
2019-03-19 10:13:08,775+02 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-1) [] Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot read property 'G' of null
        at org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostPopupView.$lambda$0(HostPopupView.java:693)
        at org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostPopupView$lambda$0$Type.eventRaised(HostPopupView.java:693)
        at org.ovirt.engine.ui.uicompat.Event.$raise(Event.java:99)

This is a new regression and user/admin can't move the host to onther DC/Cluster.

Version-Release number of selected component (if applicable):
rhvm-4.3.2.1-0.1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Try to move host to a different DC/Cluster

Actual results:
ui exception when pressing the 'Edit' host button, can't switch DC/Cluster(the list has only on cluster)

Expected results:
Must work as expected

Comment 1 Greg Sheremeta 2019-03-19 14:07:37 UTC
Please attach the entire ui.log.

Is there anything special about this Host, Cluster, or DC?

When did you first notice this behavior? Does it happen in older versions?

Comment 2 Michael Burman 2019-03-19 14:56:14 UTC
(In reply to Greg Sheremeta from comment #1)
> Please attach the entire ui.log.
> 
> Is there anything special about this Host, Cluster, or DC?
> 
> When did you first notice this behavior? Does it happen in older versions?

Hello Greg,
Long time)
No, see it on several environments and hosts. nothing special. very new regression on latest d/s build rhvm-4.3.2.1-0.1.el7.noarch
attaching the full log

Comment 3 Greg Sheremeta 2019-03-19 15:02:14 UTC
Thanks. UX hasn't changed anything. I'm guessing a virt patch -- there were several lately, including a timezone one that would be my prime suspect. @Ryan thoughts?

Comment 4 Michael Burman 2019-03-19 15:03:52 UTC
Created attachment 1545716 [details]
ui log

Comment 5 Ryan Barry 2019-03-19 15:25:44 UTC
The timezone one was merged last night, so it's unlikely to be that (since this isn't a nightly)

Do you know which call is failing, Greg?

Comment 6 Greg Sheremeta 2019-03-19 15:29:34 UTC
(In reply to Ryan Barry from comment #5)
> The timezone one was merged last night, so it's unlikely to be that (since
> this isn't a nightly)
> 
> Do you know which call is failing, Greg?

Not really. NPE in here somewhere:

    693         object.getCluster().getSelectedItemChangedEvent().addListener((ev, sender, args) -> {
    694             if (object.getCluster().getSelectedItem().supportsGlusterService()
    695                     && !object.getCluster().getSelectedItem().supportsVirtService()) {
    696                 powerManagementTab.setVisible(false);
    697                 spmTab.setVisible(false);
    698             } else {
    699                 powerManagementTab.setVisible(true);
    700                 spmTab.setVisible(true);
    701             }
    702         });

Comment 7 Ryan Barry 2019-03-19 15:33:52 UTC
A little too general, maybe...

So we're checking gluster, SPM, virt support, and power management?

I suppose we'd need to know which one of this is breaking to pin it down. Have the calls being tried manually?

Michal, what does the cluster look like from the admin panel?

Comment 8 Michael Burman 2019-03-19 18:30:40 UTC
(In reply to Ryan Barry from comment #7)
> A little too general, maybe...
> 
> So we're checking gluster, SPM, virt support, and power management?
> 
> I suppose we'd need to know which one of this is breaking to pin it down.
> Have the calls being tried manually?
> 
> Michal, what does the cluster look like from the admin panel?

Hi Ryan
Not sure i understand the question. I can say that power management doesn't enabled and I'm not using gluster. what else?

Comment 9 Michal Skrivanek 2019-03-20 05:21:58 UTC
It’s not just somewhere, you have a line number in ui.log, 693.

Comment 10 Michal Skrivanek 2019-03-20 05:40:04 UTC
Looking at git log itks not too hard to identify the culprit - https://github.com/oVirt/ovirt-engine/commit/b91c465e0be3b84f5df08a86cb77b88b5a541dc8#diff-6c15a5823cedba04eb13f1e440eabafc

Sahina, can you please take a look?

Comment 11 Sahina Bose 2019-03-20 05:42:31 UTC
Assigning to Kaustav to fix.

Comment 12 RHEL Program Management 2019-03-20 05:42:37 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 13 Greg Sheremeta 2019-03-20 10:45:26 UTC
(In reply to Michal Skrivanek from comment #9)
> It’s not just somewhere, you have a line number in ui.log, 693.

GWT doesn't work that way -- it gives you the line number where the function begins, but it doesn't give the exact line of the problem. In this case, it gave the line number of the lambda, and that's why I pasted the entire lambda in Comment 6.

Comment 14 Greg Sheremeta 2019-03-20 10:54:06 UTC
(In reply to Greg Sheremeta from comment #13)
> (In reply to Michal Skrivanek from comment #9)
> > It’s not just somewhere, you have a line number in ui.log, 693.
> 
> GWT doesn't work that way -- it gives you the line number where the function
> begins, but it doesn't give the exact line of the problem. In this case, it
> gave the line number of the lambda, and that's why I pasted the entire
> lambda in Comment 6.

To prove the point, NPE was on 694
https://gerrit.ovirt.org/#/c/98691/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java

Comment 16 Michal Skrivanek 2019-03-22 05:39:49 UTC
*** Bug 1691286 has been marked as a duplicate of this bug. ***

Comment 17 Sandro Bonazzola 2019-03-22 10:49:57 UTC
Referenced patches are not included in oVirt Engine 4.3.2 which has been released a while ago, re-targeting to 4.3.3.

Comment 18 Michal Skrivanek 2019-03-23 04:58:40 UTC
*** Bug 1691737 has been marked as a duplicate of this bug. ***

Comment 19 Greg Sheremeta 2019-03-24 21:09:48 UTC
*** Bug 1692130 has been marked as a duplicate of this bug. ***

Comment 20 Lucie Leistnerova 2019-03-25 08:18:19 UTC
What are the verification steps here?

Comment 21 Michael Burman 2019-03-25 08:29:06 UTC
(In reply to Lucie Leistnerova from comment #20)
> What are the verification steps here?

Hi Lucie
I would test that pressing edit host doesn't invoke anu UI exceptions first of all.
Also, i would check that all DCs and Clusters are available in the drop down list on edit host dialogue and that it is possible to move hosts to another DCs and clusters in the system, because this bug currently preventing the user from doing so.

Comment 22 Pavel Novotny 2019-03-29 14:24:48 UTC
This no longer reproduces in ovirt-engine-webadmin-portal-4.3.3.1-0.1.el7.noarch.
Edit host dialog now functions properly, e.g., updating host cluster or name works fine,
no UI exceptions.

Comment 23 Michael Burman 2019-03-31 06:17:17 UTC
(In reply to Pavel Novotny from comment #22)
> This no longer reproduces in
> ovirt-engine-webadmin-portal-4.3.3.1-0.1.el7.noarch.
> Edit host dialog now functions properly, e.g., updating host cluster or name
> works fine,
> no UI exceptions.

Correct. The bug can be considered as verified on 4.3.3.1-0.1.el7
Edit host doesn't invoke any UI exceptions and it's now possible once again to move hosts to another DC/CLuster

Comment 24 Pavel Novotny 2019-04-01 11:51:35 UTC
The UI regression test suite also passed with ovirt-engine-4.3.3.1-0.1.el7.noarch.

Moving to VERIFIED.

Comment 25 Alexander 2019-04-10 07:26:38 UTC
Hi,
where's can I get this package version ovirt-engine-4.3.3.1-0.1.el7.noarch, ovirt-engine-webadmin-portal-4.3.3.1-0.1.el7.noarch?
Thanks

Comment 26 Ryan Barry 2019-04-10 10:20:22 UTC
These are available in upstream repos, Alexander. Either by hand at resources.ovirt.org, or by installing ovirt-release-4.3 and upgrading

Comment 27 Alexander 2019-04-10 11:47:46 UTC
(In reply to Ryan Barry from comment #26)
> These are available in upstream repos, Alexander. Either by hand at
> resources.ovirt.org, or by installing ovirt-release-4.3 and upgrading

Ok, thank you
I've https://resources.ovirt.org/pub/ovirt-4.3 installed and in this issue (can't edit ovirt host) too.
I think, install snapshot or wait for the update pub/ovirt-4.3

Comment 28 Greg Sheremeta 2019-04-15 13:02:25 UTC
*** Bug 1699484 has been marked as a duplicate of this bug. ***

Comment 29 Sandro Bonazzola 2019-04-16 13:58:09 UTC
This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 30 Sahina Bose 2019-04-24 09:16:07 UTC
*** Bug 1698331 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.