Spec Name or Url: http://people.redhat.com/tmraz/workrave/workrave.spec SRPM Name or Url: http://people.redhat.com/tmraz/workrave/workrave-1.8.1-2.src.rpm Description: Workrave is a program that assists in the recovery and prevention of Repetitive Strain Injury (RSI). The program frequently alerts you to take micro-pauses, rest breaks and restricts you to your daily limit. Homepage: http://workrave.org/
I suggest adding: BuildRequires: gtk2-devel gtkmm24-devel pkgconfig BuildRequires: libgnomeuimm26-devel gnome-panel-devel gettext pkgconfig BuildRequires: kdelibs-devel arts-devel gnet2-devel dbus-devel gdome2-devel and %configure \ --enable-kde \ --enable-gconf \ --enable-dbus \ --enable-xml \ But it's just my suggestion.
The BuildRequires as they are in the current spec are sufficient - other are pulled automatically as they are in the requires of the libgnomeuimm26-devel. I don't want to make workrave depending on KDE. The enable-gconf is configured automatically, enable-dbus doesn't have any effect on the sources, enable-xml overrides enable-gconf.
* Applications/Health is not in GROUPS file. I suggest Applications/Productivity, as the goal is to be more productive without RSI. * rpmbuild --rebuilding, after yum installing the BuildRequires, on FC4, it fell over when it looked for applet, perhaps this needs gnome-panel-devel, or pkg-config needs to be fixed checking for APPLET... Package libpanelapplet-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `libpanelapplet-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'libpanelapplet-2.0' found configure: error: Package requirements (libpanelapplet-2.0 >= 2.0.10) were not met. Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively you may set the APPLET_CFLAGS and APPLET_LIBS environment variables to avoid the need to call pkg-config. See the pkg-config man page for more details.
> * Applications/Health is not in GROUPS file. I suggest > Applications/Productivity, as the goal is to be more productive without RSI. Done > * rpmbuild --rebuilding, after yum installing the BuildRequires, on FC4, it fell > over when it looked for applet, perhaps this needs gnome-panel-devel, or > pkg-config needs to be fixed Fixed by adding BuildRequires: gnome-panel-devel New .spec and src.rpm uploaded. http://people.redhat.com/tmraz/workrave/workrave-1.8.1-3.src.rpm
Built on FC4, i386: * Need to use %find_lang macro, as per the PackagingGuidelines on the wiki * rpmlint output: W: workrave non-conffile-in-etc /etc/sound/events/workrave.soundlist W: workrave non-standard-dir-in-usr libexec W: workrave file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/eu/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/he/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/no/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/eo/LC_MESSAGES/workrave.po W: workrave file-not-in-%lang /usr/share/locale/lt/LC_MESSAGES/workrave.po E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/common/src/System.cc E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/HeadInfo.cc E: workrave-debuginfo wrong-script-end-of-line-encoding /usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/HeadInfo.cc E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/common/include/System.hh E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/common/src/TimerBoxControl.cc E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/common/include/TimerBoxView.hh E: workrave-debuginfo wrong-script-end-of-line-encoding /usr/src/debug/workrave-1.8.1/frontend/common/include/TimerBoxView.hhE: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/common/include/TimeBarInterface.hh E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/MicroBreakWindow.cc E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/TimerBoxGtkView.hh E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/common/include/TimerBoxControl.hh E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/MicroBreakWindow.hh E: workrave-debuginfo script-without-shellbang /usr/src/debug/workrave-1.8.1/frontend/gtkmm/src/TimerBoxGtkView.cc %find_lang with fix the lang ones. For the debug info chmod -x *.cc and *.hh files in %prep or something conffile and libexec dir can probably be ignored, at least based on precedent of other Gnome apps and applets * need a .desktop file for workrave executable, and install it with desktop-file-install * configure did check for XML::Parer, if this is important perl-libxml-enno is needed as a BuildRequires
> * Need to use %find_lang macro, as per the PackagingGuidelines on the wiki - done > For the debug info chmod -x *.cc and *.hh files in %prep or something - I don't think it's worth it as it's only a debuginfo package and the wrong permissions on the source files don't break anything > * need a .desktop file for workrave executable, and install it with desktop-file-install - created a new .desktop file > * configure did check for XML::Parer, if this is important perl-libxml-enno is needed as a BuildRequires - this is used only when intltool is run - not normally in the build process New .spec and src.rpm uploaded. http://people.redhat.com/tmraz/workrave/workrave-1.8.1-4.src.rpm
Looks good: - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc - spec file legible - source matches upstream - package compiles on FC4 i386 - no missing BR - used %find_lang - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - works APPROVED
Package built in FC-3, FC-4 and development.
Package Change Request ====================== Package Name: workrave New Branches: el6 Owners: tmraz, sundaram, jokajak
Need acks from the other maintainers here.
ACK from me.
In general, we're going to want acks from everyone you add as a maintainer for a branch besides yourseslf. Since sundram has not responded, I'll just process the request without that user. They can always be added later by clicking the appropriate buttons in pkgdb. Git done (by process-git-requests).
Package Change Request ====================== Package Name: workrave New Branches: epel7 Owners: cicku
Git done (by process-git-requests).