Bug 1690734 - The federateddeployments crd's group should be types.federation.k8s.io not primitives.federation.k8s.io in federation installation UI
Summary: The federateddeployments crd's group should be types.federation.k8s.io not pr...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Federation
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.2.0
Assignee: Sohan Kunkerkar
QA Contact: Qin Ping
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-20 06:32 UTC by Qin Ping
Modified: 2019-08-20 18:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-20 18:11:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Qin Ping 2019-03-20 06:32:55 UTC
Description of problem:
The federateddeployments crd's group should be types.federation.k8s.io not primitives.federation.k8s.io in federation installation UI 


Version-Release number of selected component (if applicable):
$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.0.0-0.nightly-2019-03-19-004004   True        False         3h39m   Cluster version is 4.0.0-0.nightly-2019-03-19-004004

Federation v2 controller-manager version: version.Info{Version:"0.0.6", GitCommit:"de6a0a909418f5ddf2d04d232b0ca55aa9cffb49", GitTreeState:"clean", BuildDate:"2019-03-14T00:43:37Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}


How reproducible:
100%


Steps to Reproduce:
1. Login webconsole with kubeadmin user
2. Catalog->OperatorHub->Federation

In the install UI, chapter: Enabling federation for new API types

Running this command produces a new CRD in the hosting cluster to be the federation API surface for the deployments resource.

kubectl get crd/federateddeployments.primitives.federation.k8s.io
No resources found.

Comment 1 Paul Morie 2019-03-20 16:35:50 UTC
This will be fixed in 0.0.7 release of the operator :)

Comment 2 Paul Morie 2019-03-29 00:09:39 UTC
Should be fixed in 0.0.7 CSV

Comment 4 Qin Ping 2019-04-01 04:59:53 UTC
Verification failed with:
$ oc get clusterversion
NAME      VERSION                        AVAILABLE   PROGRESSING   SINCE     STATUS
version   4.0.0-0.ci-2019-03-31-223338   True        False         91m       Cluster version is 4.0.0-0.ci-2019-03-31-223338

Federation v2 controller-manager version: version.Info{Version:"v0.0.7", GitCommit:"3e251608ca5357080b95a0bedc45759652f17d29", GitTreeState:"clean", BuildDate:"2019-03-22T22:30:26Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

Still need some updates for "Enabling federation for new API types" part:
1. change 'kubefed2 enable deployments.extensions \ --federation-namespace=' to 'kubefed2 enable deployments.extensions --federation-namespace=<namespace>' 
2. change
kubectl get crd/federateddeployments.types.federation.k8s.io
No resources found.
to
kubectl get crd/federateddeployments.types.federation.k8s.io -n <namespace>
NAME                                           CREATED AT
federateddeployments.types.federation.k8s.io   2019-04-01T04:54:19Z

Comment 5 Maru Newby 2019-04-10 22:22:14 UTC
(In reply to Qin Ping from comment #4)
> Verification failed with:
> $ oc get clusterversion
> NAME      VERSION                        AVAILABLE   PROGRESSING   SINCE    
> STATUS
> version   4.0.0-0.ci-2019-03-31-223338   True        False         91m      
> Cluster version is 4.0.0-0.ci-2019-03-31-223338
> 
> Federation v2 controller-manager version: version.Info{Version:"v0.0.7",
> GitCommit:"3e251608ca5357080b95a0bedc45759652f17d29", GitTreeState:"clean",
> BuildDate:"2019-03-22T22:30:26Z", GoVersion:"go1.11.2", Compiler:"gc",
> Platform:"linux/amd64"}
> 
> Still need some updates for "Enabling federation for new API types" part:
> 1. change 'kubefed2 enable deployments.extensions \ --federation-namespace='
> to 'kubefed2 enable deployments.extensions
> --federation-namespace=<namespace>' 
> 2. change
> kubectl get crd/federateddeployments.types.federation.k8s.io
> No resources found.
> to
> kubectl get crd/federateddeployments.types.federation.k8s.io -n <namespace>
> NAME                                           CREATED AT
> federateddeployments.types.federation.k8s.io   2019-04-01T04:54:19Z


Where is 'Enabling federation for new API types'?  I don't think every documented command should have to specify `--federation-namespace`, since a deployment using the default namespace (federation-system) does not require the argument.  I think it would make more sense to document the requirement to provide --federation-namespace where the federation namespace is not the default.

Comment 6 Paul Morie 2019-04-12 19:53:31 UTC
Ping is referring to content in the CSV description: https://operatorhub.io/operator/federation.v0.0.7

Ping, it looks like this is a really weird formatting bug. I'm in touch with the OLM team about it; unfortunately it looks like our CSV crashes the preview tool at: https://operatorhub.io/preview

Comment 7 Qin Ping 2019-04-15 05:27:14 UTC
Yes, a weird formatting bug.
Seems "kubefed2 enable deployments.extensions --federation-namespace=<namespace\>" can fix it, but I don't know why.

Cause "kubefed2 enable deployments.extensions --federation-namespace=<namespace>" is good enough from the Markdown syntax.

Comment 9 Sohan Kunkerkar 2019-07-24 18:50:51 UTC
I think this is fixed in the latest version of kubefed-operator.


Note You need to log in before you can comment on or make changes to this bug.