Bug 1690911 - unidling unit tests need to be re-enabled [NEEDINFO]
Summary: unidling unit tests need to be re-enabled
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: 4.1.0
Assignee: Ricardo Carrillo Cruz
QA Contact: Meng Bo
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-20 13:06 UTC by David Eads
Modified: 2019-05-08 12:11 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-08 12:11:01 UTC
Target Upstream Version:
lserven: needinfo? (decarr)

Attachments (Terms of Use)

Description David Eads 2019-03-20 13:06:26 UTC 
To land the 1.13 rebase, the unidling controller had to be updated because the previously used clients were removed.  The new client mocks aren't compatible with the old, so we skipped the unit tests (units only) to free up the rest of the rebase.  The tests skipped in https://github.com/openshift/origin/pull/22368 need to be re-enabled.
Comment 1 David Eads 2019-03-20 13:07:20 UTC 
@derek please confirm I got the right group.
Comment 2 lserven 2019-03-27 16:30:42 UTC 
@Derek,

I think this bug should be owned by the autoscaling team, not the monitoring team. PTAL.

-Lucas
Comment 3 Frederic Branczyk 2019-04-04 08:39:23 UTC 
As commented on the pull request, this belong to network-edge, so reassigning.
Comment 4 Dan Mace 2019-04-10 13:54:28 UTC 
Spoke with Casey — Networking will handle this refactor.
Comment 5 Ricardo Carrillo Cruz 2019-04-29 10:15:27 UTC 
https://github.com/openshift/origin/pull/22588
Comment 6 Ben Bennett 2019-04-30 13:04:48 UTC 
Moving to 4.2 because this is not really a release blocker for 4.1.

Ricardo if this lands in 4.1 please just change the version back when you move to MODIFIED.  Thanks
Comment 8 Meng Bo 2019-05-08 11:42:14 UTC 
The related unit tests were added.

Close the bug.
Note You need to log in before you can comment on or make changes to this bug.