RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1691356 - Network filters are not honouring explicitly listed parameters for MAC
Summary: Network filters are not honouring explicitly listed parameters for MAC
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: libvirt
Version: 8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Daniel Berrangé
QA Contact: yalzhang@redhat.com
URL:
Whiteboard:
Depends On: 1691352 1691358
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-21 13:23 UTC by Daniel Berrangé
Modified: 2020-11-14 12:33 UTC (History)
6 users (show)

Fixed In Version: libvirt-4.5.0-25.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1691352
Environment:
Last Closed: 2019-11-05 20:48:28 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:3345 0 None None None 2019-11-05 20:49:10 UTC

Description Daniel Berrangé 2019-03-21 13:23:25 UTC 
Should affect libvirt-4.5.0-23.el8 too, given upstream change timeframe

+++ This bug was initially created as a clone of Bug #1691352 +++

Description of problem:

When using a network filter, libvirt will automatically set a MAC parameter, and sometimes a IP parameter too.

These defaults are not always correct, so the user is supposed to be able to override them, for example to list multiple values:

    <interface type='network'>
      <mac address='52:54:00:7b:35:93'/>
      <source network='default' bridge='virbr0'/>
      <target dev='vnet0'/>
      <model type='rtl8139'/>
      <filterref filter='clean-traffic'>
        <parameter name='IP' value='104.207.129.11'/>
        <parameter name='IP' value='104.207.129.12'/>
        <parameter name='MAC' value='52:54:00:7b:35:93'/>
        <parameter name='MAC' value='52:54:00:7b:35:94'/>
      </filterref>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </interface>

Unfortunately a bug in refactoring of nwfilter led to the overrides no longer being honoured for MAC, and sometimes not honoured for IP

This is due to upstream commit d1a7c08eb in 4.5.0

Version-Release number of selected component (if applicable):
libvirt-5.0.0-7.el8

How reproducible:


Steps to Reproduce:
1. Create a guest with nwfilter referencing 'clean-traffic' and add 2 IP and 2 MAC address parameters in the XML
2. Start the guest
3. Look at the 'virsh nwfilter-binding-dumpxml $TAPDEVNAME' output to validate the parameters are still present

Actual results:
The parameters are sometimes missing

Expected results:
The parameters from domain XML are copied to nwfilter binding XML
Comment 1 Daniel Berrangé 2019-03-22 10:58:59 UTC 
Upstream fix

commit 01e11ebcb6e8f24662b7c67b70134c192785691c
Author: Nikolay Shirokovskiy <nshirokovskiy>
Date:   Wed Mar 20 16:05:59 2019 +0300

    nwfilter: fix adding std MAC and IP values to filter binding
Comment 4 yalzhang@redhat.com 2019-07-03 09:33:48 UTC 
verify on libvirt-4.5.0-29.module+el8.1.0+3567+07fd3313.x86_64 with the same steps in bug 1691358
Comment 6 errata-xmlrpc 2019-11-05 20:48:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3345
Note You need to log in before you can comment on or make changes to this bug.