Created attachment 1548576 [details] virt-v2v debug log Description of problem: Useless info displays during virt-v2v conversion: Exception AttributeError: "'module' object has no attribute 'dump_plugin'" in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored Version-Release number of selected component (if applicable): virt-v2v-1.40.2-2.el7.x86_64 libguestfs-1.40.2-2.el7.x86_64 libvirt-4.5.0-10.el7_6.6.x86_64 qemu-kvm-rhev-2.12.0-25.el7.x86_64 python-2.7.5-81.el7.x86_64 python-libs-2.7.5-81.el7.x86_64 How reproducible: 100* Steps to Reproduce: 1. Convert a vm from esxi server to rhv by virt-v2v command. # virt-v2v -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-debian9.6-x86_64-bug1481930 --password-file /tmp/passwd -o rhv-upload -oc https://ibm-x3250m5-03.rhts.eng.pek2.redhat.com/ovirt-engine/api -os nfs_data -op /tmp/rhvpasswd -oo rhv-cafile=/home/ca.pem -oo rhv-direct=true -oo rhv-cluster=nfs -of raw Exception AttributeError: "'module' object has no attribute 'dump_plugin'" in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored [ 0.2] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-debian9.6-x86_64-bug1481930 [ 2.5] Creating an overlay to protect the source from being modified ... Actual results: Info displays during conversion: Exception AttributeError: "'module' object has no attribute 'dump_plugin'" in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored Expected results: Fix it. Additional info:
FWIW there is nothing in virt-v2v which calls any function called dump_plugin. I wonder if it's something to do with the oVirt SDK.
Looks like nbdkit issue to me. What is the version of nbdkit?
Please include also version of the python plugin, i.e. nbdkit-plugin-python2 RPM
From the log the command which fails is: nbdkit python '/var/tmp/v2v.dvwZLS/rhv-upload-plugin.py' --dump-plugin >/dev/null Exception AttributeError: "'module' object has no attribute 'dump_plugin'" in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored
I'm able to reproduce this locally with: nbdkit-1.8.0-1.el7.x86_64 nbdkit-plugin-python2-1.8.0-1.el7.x86_64 nbdkit-plugin-python-common-1.8.0-1.el7.x86_64 python-ovirt-engine-sdk4-4.3.0-2.20190315gitfd728f8.el7.x86_64 With the ./rhv-upload-plugin.py file copied from the rhel-7.7 branch of the virt-v2v sources: $ nbdkit python2 ./rhv-upload-plugin.py --dump-plugin >/dev/null Exception AttributeError: "'module' object has no attribute 'dump_plugin'" in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored
A minimal reproducer for this: ----------- /tmp/plugin.py --- import logging def open(readonly): pass def get_size(h): pass def pread(h, count, offset): pass ------------------------------ $ nbdkit python /tmp/plugin.py --dump-plugin >/dev/null Exception AttributeError: "'module' object has no attribute 'dump_plugin'" in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored Removing "import logging" makes the warning go away.
OK I see, it's just a warning caused by a left over Python error. I fixed it upstream: https://github.com/libguestfs/nbdkit/commit/466b92be2fd0af2cf734ccc567c39c11586c7be3
Moving to RHEL 8.
This is fixed in the 1.12.5 package.
Verify bug with builds: virt-v2v-1.40.2-13.module+el8.1.0+3975+96069438.x86_64 libguestfs-1.40.2-13.module+el8.1.0+3975+96069438.x86_64 nbdkit-1.12.5-1.module+el8.1.0+3868+35f94834.x86_64 Steps: 1.Prepare a rhel8 conversion server and install latest packages. 2.Convert a vm from esxi server to rhv by virt-v2v command. # virt-v2v -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-debian9.6-x86_64-bug1481930 --password-file /tmp/passwd -o rhv-upload -oc https://ibm-x3250m5-03.rhts.eng.pek2.redhat.com/ovirt-engine/api -os nfs_data -op /tmp/rhvpasswd -oo rhv-cafile=/home/ca.pem -oo rhv-direct=true -oo rhv-cluster=nfs -of raw [ 0.2] Opening the source -i libvirt -ic vpx://root.73.141/data/10.73.75.219/?no_verify=1 esx6.7-debian9.6-x86_64-bug1481930 [ 2.2] Creating an overlay to protect the source from being modified [ 2.7] Opening the overlay ^C Result:There are no useless info printed during virt-v2v conversion,so change the bug from ON_QA to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:3723