Bug 169361 - Review Request: nautilus-image-converter
Review Request: nautilus-image-converter
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tom "spot" Callaway
David Lawrence
http://www.bitron.ch/software/nautilu...
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-09-27 10:43 EDT by Brian Pepple
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-01-09 10:00:41 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Brian Pepple 2005-09-27 10:43:32 EDT
Spec Name or Url: http://piedmont.homelinux.org/fedora/nautilus-image-converter/nautilus-image-converter.spec
SRPM Name or Url: http://piedmont.homelinux.org/fedora/nautilus-image-converter/nautilus-image-converter-0.0.3-1.src.rpm
Description: Adds a "Resize Images..." menu item to the context menu of all images. This opens a dialog where you set the desired image size and file name. A click on "Resize" finally resizes the image(s) using ImageMagick's convert tool.
Comment 1 Tom "spot" Callaway 2005-09-27 11:40:38 EDT
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Needswork:
- needs to own the %{_datadir}/%{name}/ directory. 
You can fix this by changing:

%{_datadir}/%{name}/nautilus-image-resize.glade

to

%{_datadir}/%{name}/

As this is a minor touchup, I'm approving this package, but please make this
change before building.
Comment 2 Brian Pepple 2006-01-09 10:00:41 EST
Published.

Note You need to log in before you can comment on or make changes to this bug.