Bug 1693821 - [OSP 16] nova-novncproxy does not handle TCP RST cleanly when using SSL
Summary: [OSP 16] nova-novncproxy does not handle TCP RST cleanly when using SSL
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-nova
Version: 16.0 (Train)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: Upstream M2
: 16.0 (Train on RHEL 8.1)
Assignee: melanie witt
QA Contact: OSP DFG:Compute
URL:
Whiteboard:
Depends On: 1691580
Blocks: 1691581 1691584 1691585
TreeView+ depends on / blocked
 
Reported: 2019-03-28 17:30 UTC by melanie witt
Modified: 2023-03-21 19:14 UTC (History)
10 users (show)

Fixed In Version: openstack-nova-20.0.1-0.20191025043858.390db63.el8ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1691580
Environment:
Last Closed: 2020-02-06 14:39:53 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1816727 0 None None None 2019-03-28 17:30:57 UTC
OpenStack gerrit 644998 0 None None None 2019-03-28 17:31:58 UTC
Red Hat Product Errata RHEA-2020:0283 0 None None None 2020-02-06 14:40:44 UTC

Description melanie witt 2019-03-28 17:30:57 UTC
+++ This bug was initially created as a clone of Bug #1691580 +++

The following is paraphrased from the upstream bug report.
https://bugs.launchpad.net/nova/+bug/1816727/

This should be considered a security hardening bug as it could lead to a denial of service situation. It has been determined the same upstream.

Description of problem (nova-novncproxy):
With haproxy acting as a load balancer, but not terminating SSL. 

With that health check enabled, it was found the nova-novncproxy process CPU spiking and eventually causing the node to hang. 

It seems that the haproxy health checks initiate an SSL connection but then immediately send a TCP RST.

For most services this does not seem to be an issue, but for nova-novncproxy it repeatedly initializes NovaProxyRequestHandler which creates a full nova.compute.rpcapi.ComputeAPI instance which very quickly starts to consume significant CPU and overtake the host.

Comment 1 melanie witt 2019-04-03 17:34:32 UTC
Change merged upstream.

Comment 6 errata-xmlrpc 2020-02-06 14:39:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0283


Note You need to log in before you can comment on or make changes to this bug.