Bug 1694014

Description of problem:

/etc/ansible/facts.d/openshift.fact is not populated with updated values on Openshift Cluster unless it is manually deleted. 

Version-Release number of the following components:

$ ansible --version
ansible 2.6.6
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/arctst/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

$ rpm -qi ansible
Name        : ansible
Version     : 2.6.6
Release     : 1.el7ae
Architecture: noarch
Install Date: Fri 01 Feb 2019 11:02:42 GMT
Group       : Development/Libraries
Size        : 54376616
License     : GPLv3+
Signature   : RSA/SHA256, Mon 22 Oct 2018 06:47:48 BST, Key ID 199e2f91fd431d51
Source RPM  : ansible-2.6.6-1.el7ae.src.rpm
Build Date  : Sat 20 Oct 2018 00:09:16 BST
Build Host  : ppc-048.build.eng.bos.redhat.com
Relocations : (not relocatable)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
Vendor      : Red Hat, Inc.
URL         : http://ansible.com
Summary     : SSH-based configuration management, deployment, and task execution system
Description :

How reproducible:

Always

Steps to Reproduce:
1. Check for existing /etc/ansible/facts.d/openshift.fact configuration and verify the existing values:

# cat /etc/ansible/facts.d/openshift.fact | python -m json.tool

2. Change a single associated variable in inventory file (Eg. maximumFileRetentionDays) which is present in /etc/ansible/facts.d/openshift.fact file. Example,

BEFORE:
"audit_config": {
            "auditFilePath": "/var/lib/origin/openshift-audit.log",
            "enabled": true,
            "maximumFileRetentionDays": 7,
            "maximumFileSizeMegabytes": 10,
            "maximumRetainedFiles": 3
},

EXPECTED CHANGE:
"audit_config": {
            "auditFilePath": "/var/lib/origin/openshift-audit.log",
            "enabled": true,
            "maximumFileRetentionDays": 11,		=============> Value to be changed here after playbook run
            "maximumFileSizeMegabytes": 10,
            "maximumRetainedFiles": 3
},

3. Inventory file has updated value before running playbook:

openshift_master_audit_config={"enabled": true, "auditFilePath": "/var/lib/origin/openshift-audit.log", "maximumFileRetentionDays": 11, "maximumFileSizeMegabytes": 10, "maximumRetainedFiles": 3}

4. I ran following playbook to test if the change is reflected in /etc/ansible/facts.d/openshift.fact or not:

$ ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift_facts.yml -vv


5. After running the playbook, there was NO CHANGE done to /etc/ansible/facts.d/openshift.fact file at all. Infact, none of the hosts had any 'changed' tasks at all.


Expected results:

The python script /usr/share/ansible/openshift-ansible/roles/openshift_facts/library/openshift_facts.py should ideally show same behavior that any idempotent module of Ansible would (i.e, re-run of playbooks should reflect the changes from inventory in the custom facts file at /etc/ansible/facts.d/openshift.fact).

Each playbook run should reflect the change in inventory file.

Currently, removal logic resides in 
/usr/share/ansible/openshift-ansible/playbooks/adhoc/uninstall_openshift.yml which would require to uninstall the cluster and install it again for a small change.