Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/regexxer.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/regexxer-0.8-1.fc4.src.rpm Description: Regexxer is a nifty GUI search/replace tool featuring Perl-style regular expressions. If you need project-wide substitution and youâre tired of hacking sed command lines together, then you should definitely give it a try. Comments: - license GPL and included - rpmlint looks ok
Review for release 1.fc4: * RPM name is OK * Source regexxer-0.8.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of regexxer looks OK * File list of regexxer looks OK * Works fine Minor: * Requires: gconfmm26 is useless, rpm will pick it up automatically : $ rpm -qpR regexxer-0.8-1.fc4.i386.rpm | grep gconf gconfmm26 >= 2.6.1 libgconf-2.so.4 libgconfmm-2.6.so.1 * Duplicate BuildRequires: gtkmm24-devel (required by libglademm24-devel) Please remove the hardcoded dependency on gconfmm26, and consider yourself APPROVED (do as you wish with the duplicate BR, its really minor)
Christoph, if you do changes (like the ones suggested by Aurelien in #1 that you did to the regexxer.spec between review and cvs-import) you also should describe those in the changelog and increase the release. And IMHO the imported package also should always be exatly the one that was reviewed. Additional changes like those suggest in #1 should be done directly after import. tia
Updated to release -2 with complete changelog info.
Arrived at FE servers yesterday.