Spec URL: https://atim.fedorapeople.org/for-review/yacreader.spec SRPM URL: https://atim.fedorapeople.org/for-review/yacreader-9.5.0-2.fc30.src.rpm Description: A cross platform comic reader and library manager. Fedora Account System Username: atim --- This package depends on this: https://bugzilla.redhat.com/show_bug.cgi?id=1694231
>URL: www.yacreader.org I believe this should be prefixed with the schema (http:// or https://). https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ >BuildRequires: /usr/bin/desktop-file-validate You can use "desktop-file-utils" for this. >%{_datadir}/%{name}/server/docroot/css/reset.css >[...] >%{_datadir}/%{name}/server/templates/libraries_iphone.tpl Two things here: 1. While this list will make the package own files, the directories will remain unowned. You need to add "%dir %{_datadir}/%{name}". 2. Alternatively, you can replace the whole list with just "%{_datadir}/%{name}". This will include the directory and all its files (recursively). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership >%{_mandir}/man1/%{appname}.1.gz >%{_mandir}/man1/%{appname}Library.1.gz Do not assume that man pages will be gzipped. While this is the case now, it might change sometime in the future. Use a wildcard so you can match any compression method. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
- No: %global debug_package %{nil} - qmake-qt5 → %qmake_qt5 This will pass Fedora build flags and solve the previous problem. - Just use: {_datadir}/%{name} instead of listing all files in this directory - Don't use the .gz extension for man pages, glob the extension as the compression may change in the future: %{_mandir}/man1/%{appname}.1.* %{_mandir}/man1/%{appname}Library.1.* - add gcc-c++ as a BR - Fix encoding and line encoding in %prep: yacreader.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yacreader/INSTALL.md yacreader.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yacreader/README.txt yacreader.x86_64: W: file-not-utf8 /usr/share/doc/yacreader/README.txt - Some of the source are under a different license: BSD 3-clause "New" or "Revised" License --------------------------------------- yacreader-9.5.0/QsLog/QsLog.cpp yacreader-9.5.0/QsLog/QsLog.h yacreader-9.5.0/QsLog/QsLogDest.cpp yacreader-9.5.0/QsLog/QsLogDest.h yacreader-9.5.0/QsLog/QsLogDestConsole.cpp yacreader-9.5.0/QsLog/QsLogDestConsole.h yacreader-9.5.0/QsLog/QsLogDestFile.cpp yacreader-9.5.0/QsLog/QsLogDestFile.h yacreader-9.5.0/QsLog/QsLogDestFunctor.cpp yacreader-9.5.0/QsLog/QsLogDestFunctor.h yacreader-9.5.0/QsLog/QsLogLevel.h yacreader-9.5.0/YACReaderLibrary/db/folder_item.h yacreader-9.5.0/YACReaderLibrary/db/folder_model.cpp yacreader-9.5.0/YACReaderLibrary/db/folder_model.h Expat License ------------- yacreader-9.5.0/common/pictureflow.cpp yacreader-9.5.0/common/pictureflow.h Please include them in License: and add a comment explaining the license breakdown. - http://www.yacreader.org/ is not a valid website. The correct one is https://www.yacreader.com/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: BUILDSTDERR: warning: File listed twice: /usr/share/yacreader/languages/yacreader_de.qm See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "Expat License", "GPL (v3) GNU Lesser General Public License (v3)". 1001 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/yacreader/review- yacreader/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yacreader [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: yacreader-9.5.0-2.fc31.x86_64.rpm yacreader-debuginfo-9.5.0-2.fc31.x86_64.rpm yacreader-debugsource-9.5.0-2.fc31.x86_64.rpm yacreader-9.5.0-2.fc31.src.rpm yacreader.x86_64: W: invalid-url URL www.yacreader.org yacreader.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yacreader/INSTALL.md yacreader.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/yacreader/README.txt yacreader.x86_64: W: file-not-utf8 /usr/share/doc/yacreader/README.txt yacreader-debuginfo.x86_64: W: invalid-url URL www.yacreader.org yacreader-debugsource.x86_64: W: invalid-url URL www.yacreader.org yacreader.src: W: invalid-url URL www.yacreader.org 4 packages and 0 specfiles checked; 0 errors, 7 warnings.
Done. Spec URL: https://atim.fedorapeople.org/for-review/yacreader.spec SRPM URL: https://atim.fedorapeople.org/for-review/yacreader-9.5.0-3.fc30.src.rpm --- BTW how did you find so easy which license this components and files are using?
Minor license fixes: Spec URL: https://atim.fedorapeople.org/for-review/yacreader.spec SRPM URL: https://atim.fedorapeople.org/for-review/yacreader-9.5.0-4.fc30.src.rpm
Minor license fixes #2: Spec URL: https://atim.fedorapeople.org/for-review/yacreader.spec SRPM URL: https://atim.fedorapeople.org/for-review/yacreader-9.5.0-5.fc30.src.rpm
I will review this package.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3) GNU Lesser General Public License (v3)", "BSD 3-clause "New" or "Revised" License", "Expat License", "Unknown or generated". 1001 files have unknown license. Detailed output of licensecheck in /home/vitaly/1694292-yacreader/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yacreader-debuginfo , yacreader-debugsource [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: yacreader-9.5.0-5.fc31.x86_64.rpm yacreader-debuginfo-9.5.0-5.fc31.x86_64.rpm yacreader-debugsource-9.5.0-5.fc31.x86_64.rpm yacreader-9.5.0-5.fc31.src.rpm yacreader.x86_64: W: spelling-error %description -l en_US cbr -> cir, car, ctr yacreader.x86_64: W: spelling-error %description -l en_US cbz -> Cb yacreader.x86_64: W: spelling-error %description -l en_US rar -> arr, ear, tar yacreader.src: W: spelling-error %description -l en_US cbr -> cir, car, ctr yacreader.src: W: spelling-error %description -l en_US cbz -> Cb yacreader.src: W: spelling-error %description -l en_US rar -> arr, ear, tar 4 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: yacreader-debuginfo-9.5.0-5.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- yacreader.x86_64: W: spelling-error %description -l en_US cbr -> cir, car, ctr yacreader.x86_64: W: spelling-error %description -l en_US cbz -> CBC yacreader.x86_64: W: spelling-error %description -l en_US rar -> arr, ear, tar yacreader.x86_64: W: invalid-url URL: https://www.yacreader.com <urlopen error [Errno -2] Name or service not known> yacreader-debugsource.x86_64: W: invalid-url URL: https://www.yacreader.com <urlopen error [Errno -2] Name or service not known> yacreader-debuginfo.x86_64: W: invalid-url URL: https://www.yacreader.com <urlopen error [Errno -2] Name or service not known> /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- yacreader (rpmlib, GLIBC filtered): hicolor-icon-theme ld-linux-x86-64.so.2()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.12)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Multimedia.so.5()(64bit) libQt5Multimedia.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Script.so.5()(64bit) libQt5Script.so.5(Qt_5)(64bit) libQt5Sql.so.5()(64bit) libQt5Sql.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpoppler-qt5.so.1()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libunarr.so.1()(64bit) rtld(GNU_HASH) yacreader-debugsource (rpmlib, GLIBC filtered): yacreader-debuginfo (rpmlib, GLIBC filtered): Provides -------- yacreader: application() application(YACReader.desktop) application(YACReaderLibrary.desktop) mimehandler(application/x-7z) mimehandler(application/x-cb7) mimehandler(application/x-cbr) mimehandler(application/x-cbt) mimehandler(application/x-cbz) mimehandler(application/x-pdf) mimehandler(application/x-rar) mimehandler(application/x-zip) mimehandler(inode/directory) yacreader yacreader(x86-64) yacreader-debugsource: yacreader-debugsource yacreader-debugsource(x86-64) yacreader-debuginfo: debuginfo(build-id) yacreader-debuginfo yacreader-debuginfo(x86-64) Source checksums ---------------- https://github.com/YACReader/yacreader/releases/download/9.5.0/yacreader-9.5.0-src.tar.xz : CHECKSUM(SHA256) this package : a6f25edb38c5438301b1364464903995d45bae4532a5ebc8d6586f39cdf16533 CHECKSUM(SHA256) upstream package : a6f25edb38c5438301b1364464903995d45bae4532a5ebc8d6586f39cdf16533 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1694292 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Additional licenses: GPL (v3) GNU Lesser General Public License (v3) ----------------------------------------------- yacreader-9.5.0/YACReaderLibrary/qml/YACReaderScrollView.qml yacreader-9.5.0/YACReaderLibrary/qml/YACReaderScrollViewStyle.qml Please add LGPLv3+ to License tag. > make %{?_smp_mflags} This can be replaced by %make_build macro. This minor issues can be fixes during import to SCM. Package approved.
Also please add metainfo file manually, or ask upstream to add it.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/yacreader
(In reply to Vitaly Zaitsev from comment #8) > Please add LGPLv3+ to License tag. LGPLv3+ is generally included in GPLv3+. No need to specify separately or as the maintainer wishes. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Footnote8 https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_gpl_and_lgpl
libunarr-1.0.1-3.fc30 yacreader-9.5.0-6.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-422c44ead5
libunarr-1.0.1-3.fc30, yacreader-9.5.0-6.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-422c44ead5
libunarr-1.0.1-3.fc30, yacreader-9.5.0-6.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.