Bug 1694379 - gtk_menu_popup() is deprecated in gtk 3.22; virt-manager spawns right-click menus on wrong display on some Wayland configurations; menu unusable unless virt-manager resized under menu
Summary: gtk_menu_popup() is deprecated in gtk 3.22; virt-manager spawns right-click m...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-30 22:37 UTC by jay
Modified: 2019-04-07 17:55 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-04-07 17:55:59 UTC
Embargoed:

Attachments (Terms of Use)

Description jay 2019-03-30 22:37:16 UTC 
Description of problem:
I am running virt-manager on Arch Linux up-to-date with Sway version 1.0. Right-click on a VM in virt-manager causes the resulting menu to spawn on the wrong monitor. Initially filed bug report against Sway. A Sway dev informed me that this is due to gtk_menu_popup() being deprecated as of gtk 3.22 by linking me to a related bug report. Unsure if this also applies to X as I don't have it installed, but can install it to test if required.

Version-Release number of selected component (if applicable):
virt-manager --> 2.1.0
gtk3 --> 3.24.7

How reproducible:
Every time.

Steps to Reproduce:
1. Open virt-manager on first monitor
2. Right-click a VM
3. Observe menu opening on second monitor
4. Cannot click any menu option
5. Resize virt-manager to span across to the second screen under where menu exists
6. Observe that now menu options can be selected and function.

Actual results:
As above.

Expected results:
Menu should spawn on monitor which virt-manager resides at location where mouse right clicks.

Additional info:

Link to my filed bug report against Sway (now closed): https://github.com/swaywm/sway/issues/3996
Comment 1 Cole Robinson 2019-04-02 22:03:31 UTC 
Thanks for the report. I pushed a branch upstream attempting to fix, can you give it a shot?

git clone https://github.com/crobinso/virt-manager
cd virt-manager
git checkout popup
./virt-manager --debug
Comment 2 jay 2019-04-05 22:13:51 UTC 
Sorry for the delay- I was not expecting such a fast turnaround. Testing your listed branch indeed fixes this problem for me. I tested both right clicking on VMs, using the shutdown menu and its submenu, and spawning delete and clone windows- all works on whichever display virt-manager currently occupies. Do you need a debug output to sign this off slash merge with master? I can provide this if needed, but no errors are present in output- just debug output that one would expect. Thanks for the fix!
Comment 3 Cole Robinson 2019-04-07 17:55:59 UTC 
Nope no official signoff needed, I just wanted to make sure they are working because I don't have a setup for testing. I've pushed the changes now, thanks
Note You need to log in before you can comment on or make changes to this bug.